chore(ci): bump Unit Test (PR) to xlarge to complete FXA-13473 mitigation#20454
Closed
vpomerleau wants to merge 1 commit into
Closed
chore(ci): bump Unit Test (PR) to xlarge to complete FXA-13473 mitigation#20454vpomerleau wants to merge 1 commit into
vpomerleau wants to merge 1 commit into
Conversation
…tion Because: - The `Unit Test (PR)` job in CircleCI runs on `default: large` (8 GB RAM), which is not enough headroom once `nx run-many --parallel=2` spawns two packages' jest processes, each with `maxWorkers: 4`. packages/fxa-auth-server/lib/metrics/context.spec.ts uses `jest.resetModules()` + `require('./context')` in every test, which retains a large require tree (joi + fxa-shared + validators); under --coverage this regularly OOM-kills a jest worker with SIGKILL. - FXA-13473 tracks the root-cause refactor (unscheduled), and its interim mitigation was to bump the Unit Test jobs to `xlarge`. That bump landed for `Unit Test` (tagged deploy, line 1115) and `Unit Test (nightly)` (line 1244) but was not applied to `Unit Test (PR)` (line 926), so PR runs still hit the OOM. This commit: - Adds `resource_class: xlarge` to the `Unit Test (PR)` workflow entry, matching the tagged-deploy and nightly variants. Uses more CircleCI credits per PR build but eliminates the SIGKILL flake until FXA-13473 lands.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the CircleCI PR test workflow to allocate more compute resources to unit tests, aligning PR runs with the tagged-deploy and nightly unit test jobs to reduce OOM-related SIGKILL failures.
Changes:
- Set
resource_class: xlargefor theUnit Test (PR)workflow job in CircleCI config.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vbudhram
reviewed
Apr 27, 2026
| - fail-fast | ||
| - unit-test: | ||
| name: Unit Test (PR) | ||
| resource_class: xlarge |
Contributor
There was a problem hiding this comment.
imo I think we should fix the underlying issue before bumping this up
Contributor
|
@vpomerleau Trade you #20465 |
Contributor
Author
|
Closing in favour of #20465 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resource_class: xlargeto theUnit Test (PR)workflow entry in.circleci/config.yml(line 927), matching theUnit Test(tagged deploy, line 1115) andUnit Test (nightly)(line 1244) variants.jest.resetModules()pattern inpackages/fxa-auth-server/lib/metrics/context.spec.ts). FXA-13473 remains the tracking ticket for the proper refactor.Why now
The flake has hit multiple PRs this week. Example: PR #20452 — today, unrelated @apollo/server removal, failed with:
Classic OOM-killer fingerprint (kernel SIGKILL, zero test failures). Isolated measurement of
context.spec.tswith--coverageshows ~616 MB RSS per worker; withnx --parallel=2×maxWorkers: 4that can easily spike past thelargecontainer's 8 GB ceiling.Test plan
xlargeexecutor in its build log🤖 Generated with Claude Code