Skip to content

chore(payments-next): replace esbuild with tsc/ts-node in apps/payments/next#20437

Merged
dschom merged 1 commit intomainfrom
esbuild-removal/payments-next
May 5, 2026
Merged

chore(payments-next): replace esbuild with tsc/ts-node in apps/payments/next#20437
dschom merged 1 commit intomainfrom
esbuild-removal/payments-next

Conversation

@dschom
Copy link
Copy Markdown
Contributor

@dschom dschom commented Apr 23, 2026

Split of #20390 into per-folder PRs. Scope: apps/payments/next.

Because

  • We want to test & develop with what we deploy.

This pull request

Issue that this pull request solves

Closes: FXA-13523

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).
  • I have manually reviewed all AI generated code.

How to review (Optional)

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

There's a lot of cron jobs in FxA. I'm thinking we just need to keep an eye on these during next deployment to make sure something didn't get overlooked here.

@dschom dschom requested a review from a team as a code owner April 23, 2026 19:50
Copy link
Copy Markdown
Contributor

@StaberindeZA StaberindeZA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thank you!

…ts/next

Because:
- We want to test & develop with what we deploy.

This commit:
- Part of the esbuild -> tsc/ts-node migration (split of a6d1a55, PR #20390).
- Scope: files under apps/payments/next.
@dschom dschom force-pushed the esbuild-removal/payments-next branch from 8a6a77b to e3152c0 Compare May 5, 2026 17:16
@dschom dschom merged commit 8b9ab88 into main May 5, 2026
20 checks passed
@dschom dschom deleted the esbuild-removal/payments-next branch May 5, 2026 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants