Skip to content

chore(auth-server): add project.json for VSCode test explorer #20377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nshirley wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −0
Open

chore(auth-server): add project.json for VSCode test explorer #20377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/fxa-auth-server/jest.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

module.exports = {
displayName: 'fxa-auth-server',
preset: 'ts-jest',
testEnvironment: 'node',
rootDir: '.',
Expand Down
16 changes: 16 additions & 0 deletions packages/fxa-auth-server/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
{
"name": "fxa-auth-server",
"$schema": "../../node_modules/nx/schemas/project-schema.json",
"sourceRoot": "packages/fxa-auth-server",
"projectType": "application",
"tags": ["scope:server:auth", "type:core"],
"targets": {
"test-unit-jest": {
"executor": "@nx/jest:jest",
"options": {
"jestConfig": "packages/fxa-auth-server/jest.config.js",
"passWithNoTests": true
}
Comment on lines +9 to +13
Copy link

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

outputs is currently limited to the junit directory under artifacts/tests, but this target runs Jest and jest.config.js writes coverage to ../../artifacts/coverage/fxa-auth-server-jest when --coverage is enabled. With the current outputs, Nx caching/artifact tracking may miss the coverage directory, and the hard-coded path duplicates the project name. Consider either removing the explicit outputs (rely on defaults) or using placeholders and including the coverage output directory as well.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor Author

@nshirley nshirley Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is currently only added so the vscode explorer can discover the tests, this isn't necessarily an issue. But, I'll remove the outputs and rely on the default for now

}
}
}
Loading