feat(etl): Update subscription deletion ETL scripts #9216
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| --- | ||
| friendly_name: Subscription Platform Backend Cirrus Delete Events | ||
| description: Deletion events for subscription platform backend cirrus, derived | ||
| from payments-api GKE logs containing pre-derived nimbus_user_id | ||
| owners: | ||
| - dalvarez@mozilla.com | ||
| labels: | ||
| incremental: true | ||
| schedule: daily | ||
| table_type: client_level | ||
| scheduling: | ||
| dag_name: bqetl_fxa_events | ||
| bigquery: | ||
| time_partitioning: | ||
| type: day | ||
| field: submission_timestamp | ||
| require_partition_filter: false | ||
| require_column_description: true | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| SELECT | ||
| MIN(`timestamp`) AS submission_timestamp, | ||
| jsonPayload.fields.nimbus_user_id AS nimbus_user_id, | ||
| FROM | ||
| `moz-fx-fxa-prod.gke_fxa_prod_log.stderr` | ||
| WHERE | ||
| ( | ||
| DATE(_PARTITIONTIME) | ||
| BETWEEN DATE_SUB(@submission_date, INTERVAL 1 DAY) | ||
| AND DATE_ADD(@submission_date, INTERVAL 1 DAY) | ||
| ) | ||
| AND DATE(`timestamp`) = @submission_date | ||
| AND jsonPayload.type = 'glean.user.delete' | ||
| AND jsonPayload.fields.nimbus_user_id IS NOT NULL | ||
| GROUP BY | ||
| jsonPayload.fields.nimbus_user_id |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,9 @@ | ||||||||
| fields: | ||||||||
| - name: submission_timestamp | ||||||||
| type: TIMESTAMP | ||||||||
| mode: NULLABLE | ||||||||
|
Contributor
There was a problem hiding this comment. A description is useful here because the meaning of
Suggested change
Contributor
Author
There was a problem hiding this comment. Updated to add |
||||||||
| description: Earliest timestamp of the account deletion log entry for this nimbus_user_id on the given date | ||||||||
| - name: nimbus_user_id | ||||||||
| type: STRING | ||||||||
| mode: NULLABLE | ||||||||
| description: Pre-derived Nimbus user identifier logged by payments-api at account deletion time | ||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The expectation is that new tables have column descriptions in the schema.yaml and this should be set
Creating tables via the cli will add this but can get missed when copy/pasting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to add
require_column_description: true