Remove comment from metaschema that some fields are not implemented#791
Open
badboy wants to merge 1 commit into
Open
Remove comment from metaschema that some fields are not implemented#791badboy wants to merge 1 commit into
badboy wants to merge 1 commit into
Conversation
akkomar
requested changes
Oct 31, 2023
Contributor
akkomar
left a comment
There was a problem hiding this comment.
These fields were proposed in https://docs.google.com/document/d/1oNi-eX_IPIZa8C0h5GZnWTM0WFivZ1hPMgMMX3c3HHs/edit#heading=h.36jrolbv6nko
It hasn't been fully implemented, i.e. pipeline still parses URI to determine destination dataset so these descriptions are correct.
Contributor
Author
Hm, I see. but they are in use by some parts though. |
It seems those fields are actually in use.
60eefef to
e59d451
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems those fields are actually in use.
Checklist for reviewer:
./.github/push-to-trigger-integration <username>:<branchname>For glean changes:
templates/include/glean/CHANGELOG.mdFor modifications to schemas in restricted namespaces (see
CODEOWNERS):