Skip to content

Bug 1996675 - Add homepage/shortcuts_library source to top sites telemetry. r=gl#315

Closed
devotaaabel wants to merge 1 commit into
mozilla-firefox:autolandfrom
devotaaabel:26-07-02-shortcuts-telem
Closed

Bug 1996675 - Add homepage/shortcuts_library source to top sites telemetry. r=gl#315
devotaaabel wants to merge 1 commit into
mozilla-firefox:autolandfrom
devotaaabel:26-07-02-shortcuts-telem

Conversation

@devotaaabel

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

View this pull request in Lando to land it once approved.

@lando-web lando-web Bot requested a review from a team July 2, 2026 16:32
Comment thread mobile/android/fenix/app/metrics.yaml
@mozilla-code-review

Copy link
Copy Markdown

No new issues detected. This pull request is 🆗

@devotaaabel devotaaabel force-pushed the 26-07-02-shortcuts-telem branch from 20ce10a to f3d5a1d Compare July 2, 2026 22:10
@lando-web lando-web Bot requested a review from a team July 2, 2026 22:10
@mozilla-code-review

Copy link
Copy Markdown

No new issues detected. This pull request is 🆗

@devotaaabel

Copy link
Copy Markdown
Contributor Author

@mozilla-code-review mozilla-code-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue has been found in this revision.

1 issue is located outside of the patch:

  • Cargo.lock:None Error: Crate depends on a vulnerable version of crossbeam-epoch.

Advisory:
Invalid pointer dereference in fmt::Pointer impl for Atomic and Shared when the underlying pointer is invalid
Package: crossbeam-epoch
ID: RUSTSEC-2026-0204
Report date: 2026-07-06
Affected versions of fmt::Display dereference the underlying pointer. This causes a invalid pointer dereference e.g., when a pointer created with Atomic::null or Shared::null. fmt::Debug impls and pre-0.9 fmt::Display impls, which do not dereference pointers, are not affected by this issue.
URL: crossbeam-rs/crossbeam#1276
Patched versions: [
">=0.9.20"
]
Unaffected versions: [
"<0.9.0"
]
Advisory metadata: {
"aliases": [],
"related": [],
"collection": "crates",
"categories": [],
"keywords": [
"NULL-pointer-dereference"
],
"informational": null,
"references": [],
"source": null,
"withdrawn": null,
"license": "CC0-1.0"
}

Package info: {
"name": "crossbeam-epoch",
"version": "0.9.14",
"source": "registry+https://github.com/rust-lang/crates.io-index",
"checksum": "46bd5f3f85273295a9d14aedfb86f6aadbff6d8f5295c4a9edb08e819dcf5695",
"dependencies": [
{
"name": "autocfg",
"version": "1.1.0",
"source": null
},
{
"name": "cfg-if",
"version": "1.0.0",
"source": "registry+https://github.com/rust-lang/crates.io-index"
},
{
"name": "crossbeam-utils",
"version": "0.8.21",
"source": "registry+https://github.com/rust-lang/crates.io-index"
},
{
"name": "memoffset",
"version": "0.8.999",
"source": null
},
{
"name": "scopeguard",
"version": "1.1.0",
"source": "registry+https://github.com/rust-lang/crates.io-index"
}
],
"replace": null
} [cargo-audit: source-test-mozlint-cargo-audit]

@devotaaabel devotaaabel force-pushed the 26-07-02-shortcuts-telem branch from a512416 to 6326e7f Compare July 7, 2026 19:38
@mozilla-code-review mozilla-code-review Bot dismissed their stale review July 7, 2026 22:19

This review is now deprecated.

@mozilla-code-review

Copy link
Copy Markdown

Previous issues have been fixed. This pull request is 🆗

lando-worker Bot pushed a commit that referenced this pull request Jul 8, 2026
@lando-worker

lando-worker Bot commented Jul 8, 2026

Copy link
Copy Markdown

Pull request closed by commit a87dc1a

@lando-worker lando-worker Bot closed this Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants