Skip to content

Bug 2035772 - Add vertical scroll modifier to Page Summaries Settings Screen #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nicholaspoon03 wants to merge 1 commit into from
+33 −1
Closed

Bug 2035772 - Add vertical scroll modifier to Page Summaries Settings Screen #309

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 33 additions & 1 deletion ...ze/src/main/java/mozilla/components/feature/summarize/settings/SummarizeSettingsScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,16 @@ package mozilla.components.feature.summarize.settings

import androidx.compose.foundation.background
import androidx.compose.foundation.clickable
import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.height
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.rememberScrollState
import androidx.compose.foundation.selection.toggleable
import androidx.compose.foundation.verticalScroll
import androidx.compose.material3.Icon
import androidx.compose.material3.LocalMinimumInteractiveComponentSize
import androidx.compose.material3.MaterialTheme
Expand All @@ -21,13 +24,17 @@ import androidx.compose.runtime.Composable
import androidx.compose.runtime.CompositionLocalProvider
import androidx.compose.runtime.LaunchedEffect
import androidx.compose.runtime.getValue
import androidx.compose.runtime.mutableStateOf
import androidx.compose.runtime.remember
import androidx.compose.runtime.setValue
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.res.painterResource
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.semantics.Role
import androidx.compose.ui.semantics.clearAndSetSemantics
import androidx.compose.ui.text.style.TextDecoration
import androidx.compose.ui.tooling.preview.PreviewLightDark
import androidx.compose.ui.unit.dp
import androidx.lifecycle.compose.collectAsStateWithLifecycle
import mozilla.components.compose.base.Switch
Expand Down Expand Up @@ -82,7 +89,8 @@ fun SummarizeSettingsContent(
modifier: Modifier = Modifier,
) {
Column(
modifier = modifier.fillMaxWidth(),
modifier = modifier.fillMaxWidth()
.verticalScroll(rememberScrollState()),
) {
SwitchRow(
label = stringResource(id = R.string.mozac_summarize_settings_summarize_pages),
Expand Down Expand Up @@ -226,3 +234,27 @@ internal fun SettingsAppBar(
}

private const val DISABLED_ALPHA = 0.38f

@Composable
@PreviewLightDark
private fun SummarizeSettingsContentPreview() {
AcornTheme {
var isFeatureEnabled by remember { mutableStateOf(true) }
var isGestureEnabled by remember { mutableStateOf(false) }

Box(
modifier = Modifier.background(MaterialTheme.colorScheme.background),
) {
SummarizeSettingsContent(
state = SummarizeSettingsState(
isFeatureEnabled = isFeatureEnabled,
isGestureEnabled = isGestureEnabled,
),
onSummarizePagesToggled = { isFeatureEnabled = !isFeatureEnabled },
onShakeToSummarizeToggled = { isGestureEnabled = !isGestureEnabled },
onLearnMoreClicked = {},
onShakeSensitivityChanged = {},
)
}
}
}
Loading