-
Notifications
You must be signed in to change notification settings - Fork 0
Phase 29: NPC memory retrieval quality #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
964cd40
test(29-01): add failing forgetting-curve score tests
moyunzero f93f4bd
feat(29-01): implement Ebbinghaus recency scoring helpers
moyunzero 64cde5f
test(29-01): add SQL/TestMemoryBackend forgetting-curve parity tests
moyunzero e0154b8
feat(29-01): sync forgetting-curve score in SQL and TestMemoryBackend
moyunzero 325eef6
test(29-02): add failing test for Redis dialogue session
moyunzero e571e29
feat(29-02): implement Redis+Map dialogue session layer
moyunzero eda7339
feat(29-02): wire getRecentTurnsAsync in npc-chat job path
moyunzero 887e050
test(29-03): add failing verify:pgvector script entry
moyunzero 662e6eb
feat(29-03): implement pgvector halfvec capability probe
moyunzero 2b1fabd
feat(29-03): add halfvec HNSW and attitude semantic migrations
moyunzero ee23796
test(29-04): add failing tests for overfetch + forgetting-curve rerank
moyunzero bebec88
feat(29-04): distance overfetch then forgetting-curve rerank
moyunzero d346d89
test(29-05): add failing test for Chinese mood clamp
moyunzero 8985f6a
feat(29-05): implement clampSemanticState Chinese 8-mood
moyunzero 1b89081
test(29-05): add failing tests for attitude semantic upsert
moyunzero df95576
feat(29-05): upsert semantic attitudes without reputation wipe
moyunzero 620607b
test(29-09): add failing test for relationshipPropagation
moyunzero eaa5764
feat(29-09): implement computeRelationshipPropagationDeltas
moyunzero ece70bf
test(29-09): add failing collective propagation service tests
moyunzero 54d8c0a
feat(29-09): wire 2-hop relationship propagation in CollectiveService
moyunzero 67fba72
test(29-06): add failing structured reflect tests
moyunzero befe9fa
feat(29-06): implement run_reflect_llm_structured
moyunzero 7e6c2f1
test(29-06): add failing storeReflection semantic tests
moyunzero abb6526
feat(29-06): wire structured reflect to attitudes write
moyunzero 6135493
feat(29-07): CollectiveContext carries attitude semantic
moyunzero a3390a8
test(29-07): add failing tests for attitude semantic injection
moyunzero 62c36ef
feat(29-07): inject semantic into speak attitude context
moyunzero 96b416c
docs(29-07): CONTRACTS C-05 public strip for semantic
moyunzero ed33d56
fix(29-08): align speak benchmark T_think with composer aria-busy
moyunzero 78b7313
docs(29-08): record Phase 29 speak benchmark REGRESS
moyunzero 7708698
fix(29): narrow reply audit and add Map-evict D-SESS UAT
moyunzero ba71e38
docs: credit Fantasy Tileset for Beginning Fields home map
moyunzero b82d1d2
test(29): mock relationship list in CollectiveService unit tests
moyunzero 7c4bcac
fix(29): address CR — COALESCE parity, PROP overfetch, rehydrate race
moyunzero File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Constrain duplicated state-change patterns to affirmative physical actions.
Both guards can replace legitimate dialogue with the fallback because unanchored phrases match figurative, interrogative, and negated text.
apps/ai-gateway/app/guards/reply.py#L10-L15: refine the English/Chinese alternatives and add question/negation regression cases.workers/agent-worker/src/guard/reply_audit.py#L8-L11: apply the identical refined patterns and tests.📍 Affects 2 files
apps/ai-gateway/app/guards/reply.py#L10-L15(this comment)workers/agent-worker/src/guard/reply_audit.py#L8-L11🤖 Prompt for AI Agents