Skip to content

[Fixes:#2402] Remove redundant draft discard for unmatched LOST packets; workflow manager already discards REJECTED packets #2404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ckm007 merged 1 commit into from
Sep 17, 2026
Merged

[Fixes:#2402] Remove redundant draft discard for unmatched LOST packets; workflow manager already discards REJECTED packets #2404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions ...age/src/main/java/io/mosip/registration/processor/biodedupe/stage/BioDedupeProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,13 +635,7 @@ private void lostPacketPostAbisIdentification(InternalRegistrationStatusDto regi
regProcLogger.info(LoggerFileConstant.SESSIONID.toString(), LoggerFileConstant.REGISTRATIONID.toString(),
registrationStatusDto.getRegistrationId(),
BioDedupeConstants.NO_MATCH_FOUND_FOR_LOST + registrationId);
// Discard the draft since this LOST packet has no biometric match.
try {
idrepoDraftService.idrepoDiscardDraft(registrationId);
} catch (IdrepoDraftException | IdrepoDraftReprocessableException | ApisResourceAccessException e) {
regProcLogger.warn(LoggerFileConstant.SESSIONID.toString(), LoggerFileConstant.REGISTRATIONID.toString(),
registrationId, "Failed to discard draft on LOST no-match (non-fatal): " + e.getMessage());
}
// Draft discard is handled by WorkflowInternalActionVerticle.processCompleteAsRejected()

} else if (matchedRegIds.size() == 1) {

Expand Down
23 changes: 2 additions & 21 deletions ...src/test/java/io/mosip/registration/processor/biodedupe/stage/BioDedupeProcessorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,27 +524,8 @@ public void testLostPacketValidationMatchedIdEmpty() throws ApisResourceAccessEx
MessageDTO messageDto = bioDedupeProcessor.process(dto, stageName);
assertFalse(messageDto.getIsValid());
assertFalse(messageDto.getInternalError());
Mockito.verify(idrepoDraftService, Mockito.times(1)).idrepoDiscardDraft("reg1234");
}

@Test
public void testLostPacketNoMatch_DiscardThrows_StillRejectsWithoutInternalError() throws Exception {
registrationStatusDto.setRegistrationId("reg1234");
registrationStatusDto.setRegistrationType("LOST");
Mockito.when(registrationStatusService.getRegistrationStatus(any(), any(), any(), any())).thenReturn(registrationStatusDto);
Mockito.when(abisHandlerUtil.getPacketStatus(any())).thenReturn(AbisConstant.POST_ABIS_IDENTIFICATION);
ProcessedMatchedResult processedMatchedResult = new ProcessedMatchedResult();
processedMatchedResult.setMatchedResults(new HashSet<>());
Mockito.when(abisHandlerUtil.getProcessedMatchedResult(any(), any(), anyInt(), any(), any()))
.thenReturn(processedMatchedResult);
Mockito.when(idrepoDraftService.idrepoDiscardDraft(anyString()))
.thenThrow(new IdrepoDraftException("IDR-IDC-005", "discard failed"));

MessageDTO messageDto = bioDedupeProcessor.process(dto, stageName);

assertFalse(messageDto.getIsValid());
assertFalse(messageDto.getInternalError());
Mockito.verify(idrepoDraftService, Mockito.times(1)).idrepoDiscardDraft("reg1234");
// Draft discard is handled by WorkflowInternalActionVerticle.processCompleteAsRejected()
Mockito.verify(idrepoDraftService, Mockito.never()).idrepoDiscardDraft(anyString());
}

@Test
Expand Down
Loading