Skip to content

Fix Kafka commit ordering after producer writes #2311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
officialasishkumar wants to merge 2 commits into
base: release-1.3.x
Choose a base branch
from
Open

Fix Kafka commit ordering after producer writes #2311

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5476cba
Fix Kafka commit ordering after producer writes
officialasishkumar Apr 11, 2026
9268c83
Fix Kafka partition resume on producer failure
officialasishkumar Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 38 additions & 16 deletions ...-core/src/main/java/io/mosip/registration/processor/core/eventbus/KafkaMosipEventBus.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ public void send(MessageBusAddress toAddress, MessageDTO message) {
this.eventTracingHandler.writeHeaderOnKafkaProduce(producerRecord);
Map<String, String> mdc = MDC.getCopyOfContextMap();
kafkaProducer.write(producerRecord, handler -> {
MDC.setContextMap(mdc);
setMDCContextMap(mdc);
if(handler.failed())
logger.error("Failed kafkaProducer.write {} {} ", handler.result(), handler.cause());
else
Expand Down Expand Up @@ -317,6 +317,29 @@ Future<Void> setupAutoCommitProcessing(
return promise.future();
}

private void completeProcessedRecord(KafkaConsumerRecord<String, String> record, boolean commitRecord,
Promise<Void> promise) {
if(commitRecord)
commitOffset(record.topic(), record.partition(),
record.offset(), promise);
else
promise.complete();
}

private void failPromise(Promise<Void> promise, Throwable cause, String failureMessage) {
if(cause != null)
promise.fail(cause);
else
promise.fail(failureMessage);
}

private void setMDCContextMap(Map<String, String> mdc) {
if(mdc != null)
MDC.setContextMap(mdc);
else
MDC.clear();
}

Future<Void> processRecord(MessageBusAddress toAddress,
EventHandler<EventDTO, Handler<AsyncResult<MessageDTO>>> eventHandler,
KafkaConsumerRecord<String, String> record, boolean commitRecord) {
Expand All @@ -330,14 +353,12 @@ Future<Void> processRecord(MessageBusAddress toAddress,
eventHandler.handle(eventDTO, res -> {
if (!res.succeeded() && res.cause() instanceof MessageExpiredException) {
logger.warn("Event handling failed {}", res.cause().getMessage());
if(commitRecord)
commitOffset(record.topic(), record.partition(),
record.offset(), promise);
else
promise.complete();
completeProcessedRecord(record, commitRecord, promise);
this.eventTracingHandler.closeSpan(span);
} else if(!res.succeeded()) {
logger.error("Event handling failed {}", res.cause());
promise.fail(res.cause());
failPromise(promise, res.cause(), "Event handling failed");
this.eventTracingHandler.closeSpan(span);
} else {
if(toAddress != null) {
MessageDTO messageDTO = res.result();
Expand All @@ -349,21 +370,22 @@ Future<Void> processRecord(MessageBusAddress toAddress,
getKafkaKey(messageDTO, messageBusToAddress), jsonObject.toString());
this.eventTracingHandler.writeHeaderOnKafkaProduce(producerRecord, span);
kafkaProducer.write(producerRecord, handler -> {
MDC.setContextMap(mdc);
if(handler.failed())
setMDCContextMap(mdc);
if(handler.failed()) {
logger.error("Failed kafkaProducer.write {} ", handler.result(), handler.cause());
else
failPromise(promise, handler.cause(), "Failed kafkaProducer.write");
} else {
logger.info("Success kafkaProducer.write {} ", handler.result());
completeProcessedRecord(record, commitRecord, promise);
}
MDC.clear();
this.eventTracingHandler.closeSpan(span);
Comment thread
coderabbitai[bot] marked this conversation as resolved.
});
} else {
completeProcessedRecord(record, commitRecord, promise);
this.eventTracingHandler.closeSpan(span);
}
if(commitRecord)
commitOffset(record.topic(), record.partition(),
record.offset(), promise);
else
promise.complete();
}
this.eventTracingHandler.closeSpan(span);
});
return promise.future();
}
Expand Down
100 changes: 100 additions & 0 deletions ...e/src/test/java/io/mosip/registration/processor/core/eventbus/KafkaMosipEventBusTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
import io.mosip.registration.processor.core.spi.eventbus.EventHandler;
import io.mosip.registration.processor.core.tracing.EventTracingHandler;
import io.vertx.core.AsyncResult;
import io.vertx.core.Future;
import io.vertx.core.Handler;
import io.vertx.core.Vertx;
import io.vertx.core.json.JsonObject;
Expand All @@ -55,6 +56,7 @@
import io.vertx.ext.unit.junit.VertxUnitRunner;
import io.vertx.kafka.client.common.PartitionInfo;
import io.vertx.kafka.client.consumer.KafkaConsumer;
import io.vertx.kafka.client.consumer.KafkaConsumerRecord;
import io.vertx.kafka.client.consumer.KafkaConsumerRecords;
import io.vertx.kafka.client.consumer.OffsetAndMetadata;
import io.vertx.kafka.client.consumer.impl.KafkaConsumerRecordsImpl;
Expand Down Expand Up @@ -97,6 +99,56 @@ public void setup(TestContext testContext) throws Exception {
.thenReturn(kafkaProducer);

eventTracingHandler = new EventTracingHandler(tracing, "kafka");
mockKafkaProducerWriteResult(false, null);
}


private void mockKafkaProducerWriteResult(boolean failed, Throwable cause) {
AsyncResult producerAsyncResult = Mockito.mock(AsyncResult.class);
Mockito.when(producerAsyncResult.failed()).thenReturn(failed);
Mockito.when(producerAsyncResult.succeeded()).thenReturn(!failed);
Mockito.when(producerAsyncResult.cause()).thenReturn(cause);
doAnswer((Answer<KafkaProducer<String, String>>) arguments -> {
((Handler<AsyncResult>) arguments.getArgument(1)).handle(producerAsyncResult);
return kafkaProducer;
}).when(kafkaProducer).write(any(KafkaProducerRecord.class), any(Handler.class));
}

private void mockCommitResult(boolean succeeded) {
AsyncResult<Void> voidAsyncResult = Mockito.mock(AsyncResult.class);
Mockito.when(voidAsyncResult.succeeded()).thenReturn(succeeded);
doAnswer((Answer<AsyncResult<Void>>) arguments -> {
((Handler<AsyncResult<Void>>) arguments.getArgument(1)).handle(voidAsyncResult);
return null;
}).when(kafkaConsumer).commit(anyMap(), any());
}

private EventHandler<EventDTO, Handler<AsyncResult<MessageDTO>>> prepareSuccessfulEventHandler() {
EventHandler<EventDTO, Handler<AsyncResult<MessageDTO>>> eventHandler =
Mockito.mock(EventHandler.class);
doAnswer((Answer<AsyncResult<MessageDTO>>) arguments -> {
AsyncResult<MessageDTO> asyncResultForMessageDTO = Mockito.mock(AsyncResult.class);
Mockito.when(asyncResultForMessageDTO.succeeded()).thenReturn(true);
MessageDTO messageDTO = new MessageDTO();
messageDTO.setRid("1001");
messageDTO.setReg_type(RegistrationType.NEW.name());
Mockito.when(asyncResultForMessageDTO.result()).thenReturn(messageDTO);
((Handler<AsyncResult<MessageDTO>>) arguments.getArgument(1))
.handle(asyncResultForMessageDTO);
return null;
}).when(eventHandler).handle(any(), any());
return eventHandler;
}

private KafkaConsumerRecord<String, String> prepareKafkaConsumerRecord() {
KafkaConsumerRecord<String, String> record = Mockito.mock(KafkaConsumerRecord.class);
Mockito.when(record.headers()).thenReturn(new ArrayList<>());
Mockito.when(record.key()).thenReturn("1001");
Mockito.when(record.value()).thenReturn("{\"rid\":\"1001\", \"reg_type\": \"NEW\" }");
Mockito.when(record.topic()).thenReturn(MessageBusAddress.PACKET_VALIDATOR_BUS_IN.getAddress());
Mockito.when(record.partition()).thenReturn(0);
Mockito.when(record.offset()).thenReturn(10L);
return record;
}

@After
Expand Down Expand Up @@ -306,6 +358,54 @@ public void testConsumeAndSendWithSingleCommitType(TestContext testContext) {
verify(kafkaProducer, times(testDataCount)).write(any(), any());
}


@Test
public void testProcessRecordCommitsAfterProducerWriteSuccess(TestContext testContext) {
kafkaMosipEventBus = new KafkaMosipEventBus(vertx, "localhost:9091", "group_1",
"single", "100", "30000", 60000, eventTracingHandler, caffeineCacheManager);
mockCommitResult(true);

Future<Void> result = kafkaMosipEventBus.processRecord(MessageBusAddress.PACKET_UPLOADER_OUT,
prepareSuccessfulEventHandler(), prepareKafkaConsumerRecord(), true);

assertTrue(result.succeeded());
InOrder inOrder = Mockito.inOrder(kafkaProducer, kafkaConsumer);
inOrder.verify(kafkaProducer, times(1)).write(any(KafkaProducerRecord.class), any(Handler.class));
inOrder.verify(kafkaConsumer, times(1)).commit(anyMap(), any());
}

@Test
public void testProcessRecordFailsAndDoesNotCommitWhenProducerWriteFails(TestContext testContext) {
RuntimeException producerException = new RuntimeException("producer write failed");
mockKafkaProducerWriteResult(true, producerException);
kafkaMosipEventBus = new KafkaMosipEventBus(vertx, "localhost:9091", "group_1",
"single", "100", "30000", 60000, eventTracingHandler, caffeineCacheManager);

Future<Void> result = kafkaMosipEventBus.processRecord(MessageBusAddress.PACKET_UPLOADER_OUT,
prepareSuccessfulEventHandler(), prepareKafkaConsumerRecord(), true);

assertTrue(result.failed());
assertEquals(producerException, result.cause());
verify(kafkaProducer, times(1)).write(any(KafkaProducerRecord.class), any(Handler.class));
verify(kafkaConsumer, times(0)).commit(anyMap(), any());
}

@Test
public void testProcessRecordFailsBatchFutureWhenProducerWriteFails(TestContext testContext) {
RuntimeException producerException = new RuntimeException("producer write failed");
mockKafkaProducerWriteResult(true, producerException);
kafkaMosipEventBus = new KafkaMosipEventBus(vertx, "localhost:9091", "group_1",
"batch", "100", "30000", 60000, eventTracingHandler, caffeineCacheManager);

Future<Void> result = kafkaMosipEventBus.processRecord(MessageBusAddress.PACKET_UPLOADER_OUT,
prepareSuccessfulEventHandler(), prepareKafkaConsumerRecord(), false);

assertTrue(result.failed());
assertEquals(producerException, result.cause());
verify(kafkaProducer, times(1)).write(any(KafkaProducerRecord.class), any(Handler.class));
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
verify(kafkaConsumer, times(0)).commit(anyMap(), any());
}

@Test
public void testConsumeWithAutoCommitType(TestContext testContext) {
int testDataCount = 20;
Expand Down