Refactor: Move ApplicationIdentityMigrationService and its repositories from application-service to core [MOSIP-44379]

[GOKULRAJ136]

Summary by CodeRabbit

• Refactor

  • Reorganized application and identity-migration services into shared core components.
  • Consolidated repository access under a common core layer without changing repository behavior.
  • Updated dependent services and tests to use the reorganized components.

• Tests

  • Updated test coverage references to match the shared core structure.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 8b8e2491-2084-405f-9843-6c2f87f5be52

📥 Commits

Reviewing files that changed from the base of the PR and between 45b8f6f and 86f7173.

📒 Files selected for processing (23)

• pre-registration/pre-registration-application-service/src/main/java/io/mosip/preregistration/application/repository/DocumentDAO.java
• pre-registration/pre-registration-application-service/src/main/java/io/mosip/preregistration/application/service/ApplicationService.java
• pre-registration/pre-registration-application-service/src/main/java/io/mosip/preregistration/application/service/AppointmentServiceImpl.java
• pre-registration/pre-registration-application-service/src/main/java/io/mosip/preregistration/application/service/DemographicService.java
• pre-registration/pre-registration-application-service/src/main/java/io/mosip/preregistration/application/service/DocumentService.java
• pre-registration/pre-registration-application-service/src/main/java/io/mosip/preregistration/application/service/util/CommonServiceUtil.java
• pre-registration/pre-registration-application-service/src/main/java/io/mosip/preregistration/application/service/util/DemographicServiceUtil.java
• pre-registration/pre-registration-application-service/src/main/java/io/mosip/preregistration/application/service/util/DocumentServiceUtil.java
• pre-registration/pre-registration-application-service/src/test/java/io/mosip/preregistration/application/service/ApplicationServiceTest.java
• pre-registration/pre-registration-application-service/src/test/java/io/mosip/preregistration/application/service/AppointmentServiceImplTest.java
• pre-registration/pre-registration-application-service/src/test/java/io/mosip/preregistration/application/service/DemographicServiceTest.java
• pre-registration/pre-registration-application-service/src/test/java/io/mosip/preregistration/application/service/DocumentServiceTest.java
• pre-registration/pre-registration-application-service/src/test/java/io/mosip/preregistration/application/service/util/CommonServiceUtilTest.java
• pre-registration/pre-registration-application-service/src/test/java/io/mosip/preregistration/application/test/service/AppointmentServiceTest.java
• pre-registration/pre-registration-application-service/src/test/java/io/mosip/preregistration/application/test/service/DemographicServiceTest.java
• pre-registration/pre-registration-application-service/src/test/java/io/mosip/preregistration/application/test/service/util/DemographicServiceUtilTest.java
• pre-registration/pre-registration-application-service/src/test/java/io/mosip/preregistration/application/test/service/util/DocumentServiceUtilTest.java
• pre-registration/pre-registration-core/src/main/java/io/mosip/preregistration/core/common/repository/ApplicationRepostiory.java
• pre-registration/pre-registration-core/src/main/java/io/mosip/preregistration/core/common/repository/DemographicRepository.java
• pre-registration/pre-registration-core/src/main/java/io/mosip/preregistration/core/common/repository/DocumentRepository.java
• pre-registration/pre-registration-core/src/main/java/io/mosip/preregistration/core/common/repository/RegAppointmentRepository.java
• pre-registration/pre-registration-core/src/main/java/io/mosip/preregistration/core/common/service/ApplicationIdentityMigrationService.java
• pre-registration/pre-registration-core/src/test/java/io/mosip/preregistration/core/common/service/ApplicationIdentityMigrationServiceTest.java

---

Walkthrough

The PR moves shared repositories and ApplicationIdentityMigrationService from application packages to core-common packages. Application services and tests update their imports. Repository behavior and test behavior remain unchanged.

Changes

Core package relocation

Layer / File(s)	Summary
Core repository and service declarations pre-registration/pre-registration-core/src/main/java/io/mosip/preregistration/core/common/{repository,service}/*	Repository interfaces and ApplicationIdentityMigrationService now use core-common packages.
Application service import wiring pre-registration/pre-registration-application-service/src/main/java/io/mosip/preregistration/application/{repository,service}/*	Application services, utilities, and DocumentDAO reference the relocated types.
Test package and import updates pre-registration/pre-registration-{core,application-service}/src/test/*	Tests reference the new packages. The core migration-service test also moves to the core-common service package.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

• mosip/pre-registration#1030: Relocates the same migration service and repository classes during PII compatibility changes.

Poem

Core types cross the package line,
Imports align in ordered design.
Services point to their shared home,
Tests follow where the classes roam.
No behavior shifts, no logic strays.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: moving ApplicationIdentityMigrationService and related repositories from application-service to core common packages across the codebase.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}