PII ISSUE FIXES [MOSIP-44379] #1029
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| -- ================================================================================================ | ||
| -- MOSIP Pre-Registration PII Security: Canonical User Registry Table | ||
| -- Purpose: Centralized surrogate user ID mapping for cr_by/upd_by/cr_appuser_id | ||
| -- ================================================================================================ | ||
| -- This table eliminates plaintext PII replication across the tables | ||
| -- Stores: hash(authUserId) -> UUID surrogate mapping + encrypted original for notifications/audit | ||
| -- Usage: | ||
| -- 1. Resolve: hash(authUserId) -> user_id (fast lookup) | ||
| -- 2. Store: user_id in cr_by/upd_by/cr_appuser_id/contact_info fields(instead of plaintext) | ||
| -- 3. Recover: decrypt from user_details for notifications/audit | ||
|
|
||
| -- ========== CREATE TABLE: Canonical User Registry ========== | ||
|
|
||
| CREATE TABLE IF NOT EXISTS prereg.user_details ( | ||
| user_id UUID PRIMARY KEY DEFAULT gen_random_uuid(), | ||
| identifier_hash VARCHAR(128) NOT NULL UNIQUE, | ||
| identifier_encrypted TEXT | ||
| ); | ||
|
Comment on lines
+14
to
+20
There was a problem hiding this comment. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Check if there are any other DDL or migration scripts that might populate this table with null values
echo "=== Searching for user_details references in migration/ddl scripts ==="
find . -path "*/db_scripts/*" -name "*.sql" -exec grep -l "user_details" {} \;
echo -e "\n=== Checking entity definition for nullable annotations ==="
cat pre-registration/pre-registration-core/src/main/java/io/mosip/preregistration/core/common/entity/UserDetails.java 2>/dev/null | head -50Repository: mosip/pre-registration Length of output: 1266 🏁 Script executed: # Examine the actual DDL file to confirm NOT NULL constraints
echo "=== Full DDL for user_details table ==="
cat db_scripts/mosip_prereg/ddl/user_details.sqlRepository: mosip/pre-registration Length of output: 1764 🏁 Script executed: # Find and examine UserDetailsService to verify repair logic
echo "=== Searching for UserDetailsService ==="
find . -name "UserDetailsService.java" -type f
echo -e "\n=== Checking for repair/null-handling logic ==="
find . -name "UserDetailsService.java" -type f -exec cat {} \; 2>/dev/null | head -300Repository: mosip/pre-registration Length of output: 12086 🏁 Script executed: # Check the main DDL file for any additional constraints or migration info
echo "=== Checking main DDL file ==="
grep -A 20 -B 5 "user_details" db_scripts/mosip_prereg/ddl.sql 2>/dev/null || echo "Pattern not found or file structure differs"Repository: mosip/pre-registration Length of output: 336 DDL NOT NULL constraints conflict with repair logic and partial index design. The DDL declares This contradiction creates a runtime risk: if the repair logic encounters an existing row with null values, the UPDATE will fail due to the NOT NULL constraint. Resolve this by either:
If migrating legacy data, ensure migration scripts populate these fields before applying the NOT NULL constraints. 🤖 Prompt for AI Agents |
||
|
|
||
|
|
||
| -- ========== CREATE INDEXES ========== | ||
|
|
||
| -- Primary: UNIQUE constraint covers 99% of lookups | ||
| CREATE INDEX CONCURRENTLY IF NOT EXISTS idx_prereg_user_details_hash | ||
| ON prereg.user_details(identifier_hash); | ||
|
|
||
| -- Composite for active user lookups + joins | ||
| CREATE INDEX CONCURRENTLY IF NOT EXISTS idx_prereg_user_details_active | ||
| ON prereg.user_details(user_id) WHERE identifier_encrypted IS NOT NULL; | ||
|
coderabbitai[bot] marked this conversation as resolved.
Outdated
|
||
|
|
||
|
|
||
| -- ================================================================================================ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add cols like cr_dt etc