Skip to content

#1690: Salt audit subject identifiers - #1695

Merged
JanardhanBS-SyncByte merged 5 commits into
mosip:release-1.3.xfrom
nagendra0721:release-1.3.x
Oct 15, 2026
Merged

JanardhanBS-SyncByte merged 5 commits into
mosip:release-1.3.xfrom
nagendra0721:release-1.3.x

Conversation

@nagendra0721

Copy link
Copy Markdown
Collaborator

No description provided.

Signed-off-by: nagendra0721 <nagendra0718@gmail.com>
@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 5040df37-c78b-478b-8ff4-291bb7da25ec
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

…ails

Make UinHashSaltRepo injection optional in AuditHelper and guard the
salted-hash call so audit logging never breaks bean wiring in services
without the repository (credential-request-generator, credential-service)
and never turns a successful request into a 500 (e.g. the finally-block
audit() call in IdRepoController#addIdentity) on a transient DB failure.

Signed-off-by: nagendra0721 <nagendra0718@gmail.com>
Signed-off-by: nagendra0721 <nagendra0718@gmail.com>
Signed-off-by: nagendra0721 <nagendra0718@gmail.com>
Signed-off-by: nagendra0721 <nagendra0718@gmail.com>
@JanardhanBS-SyncByte
JanardhanBS-SyncByte merged commit 7c16335 into mosip:release-1.3.x Oct 15, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants