Skip to content

Generate array-handle values from the IdSchema validator - #1694

Open
jayesh12234 wants to merge 1 commit into
mosip:developfrom
jayesh12234:fix-array-handle-schema-regex
Open

jayesh12234 wants to merge 1 commit into
mosip:developfrom
jayesh12234:fix-array-handle-schema-regex

Conversation

@jayesh12234

Copy link
Copy Markdown

Summary

  • Add Identity rewrites array-handle values such as functionalid through IdRepoUtil.generateSchemaFieldValue so they follow the live IdSchema regex.
  • Depends on apitest-commons resolving validators that live behind `` (Follow IdSchema $ref when generating handle values mosip-functional-tests#1996). Without that, a functionalid defined only as `#/definitions/functionalIdType` still falls back to a `mosip` plus digits value.

Test plan

  • Publish or use a commons build that includes the `` fix.
  • Run IdRepository_AddIdentity_withValidParameters_smoke_Pos against a schema whose functionalid regex is ^[+]*([0-9]{1})([0-9]{9})$ and confirm the request value is 10 digits.
  • Confirm email and phone handles are still filled from $ and $.

Made with Cursor

@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 19c76e58-5d61-4b68-a9b7-2a1f8dd6e4f6
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

…ity.

Signed-off-by: Jayesh Kharode <jayesh.kharode@technoforte.co.in>
@jayesh12234
jayesh12234 force-pushed the fix-array-handle-schema-regex branch from 6532499 to c70c417 Compare October 15, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants