Skip to content

DSD-10799 - #1789

Merged
mahammedtaheer merged 1 commit into
mosip:develop-1764from
jayesh12234:patch-2
Sep 8, 2026
Merged

mahammedtaheer merged 1 commit into
mosip:develop-1764from
jayesh12234:patch-2

Conversation

@jayesh12234

@jayesh12234 jayesh12234 commented Sep 8, 2026

Copy link
Copy Markdown

Removed obsolete health check endpoints for mobile ID.

Summary by CodeRabbit

  • Configuration
    • Removed internal partner and OTP health endpoints from health-check configuration.
    • Retained the mock mobile verification health endpoint.

Removed obsolete health check endpoints for mobile ID.

Signed-off-by: Jayesh Kharode <111957576+jayesh12234@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 2c1ee9b2-2663-4884-9030-a8bbd2f5d238

📥 Commits

Reviewing files that changed from the base of the PR and between 6d14fd7 and 33cd874.

📒 Files selected for processing (1)
  • api-test/src/main/resources/config/healthCheckEndpoint.properties

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The health-check configuration removes the internal partner and OTP actuator entries. The mock mobile verification actuator entry remains configured at /v1/mockmv/actuator/health.

Changes

Health-check configuration

Layer / File(s) Summary
Actuator endpoint configuration
api-test/src/main/resources/config/healthCheckEndpoint.properties
The internal partner and OTP actuator entries are removed. The mock mobile verification entry remains configured.

Priority: ⬇️ Low — Defer this health-check configuration cleanup because it only removes two obsolete actuator endpoints while retaining the mock verification endpoint.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 33cd8

This removes obsolete mobile-ID health-check configuration entries without enabling a new endpoint. No current merge-blocking production or test-behavior risk remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title contains only the issue identifier "DSD-10799". It does not describe the removal of obsolete mobile ID health check endpoints. Replace the title with a concise description, such as "Remove obsolete mobile ID health check endpoints".
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Health checks trim their route,
Two quiet endpoints fade,
Mock verification stays,
The config keeps its shape,
A smaller watchful gate.

Comment @coderabbitai help to get the list of available commands.

@mahammedtaheer
mahammedtaheer merged commit 42f86bd into mosip:develop-1764 Sep 8, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants