Refactor/refactor api#204
Closed
demigod-11 wants to merge 2 commits into
Closed
Conversation
Author
Signed-off-by: Ügochukwu Nwamanna <llousvamel11@gmail.com>
Signed-off-by: Ügochukwu Nwamanna <llousvamel11@gmail.com>
a341efe to
43f1388
Compare
Contributor
|
Hey @demigod-11 - thanks for these changes. We have a lot of areas where our code can be streamlined. Could you please compare #206 and #163 and help us understand if your improvement to the upload endpoint can be made as part of a larger suite of changes? Closing this for now. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
refactored "/gcbm/upload/miscellaneous", "/gcbm/upload/classifiers", "/gcbm/upload/disturbances" endpoints
created a service to handle the endpoint functionality thereby keeping the code clean.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
ran flask locally and pytest
Additional Context (Please include any Screenshots/gifs if relevant)
...
Checklist: