Skip to content

Refactor/refactor api#204

Closed
demigod-11 wants to merge 2 commits into
moja-global:masterfrom
demigod-11:refactor/refactor_api
Closed

Refactor/refactor api#204
demigod-11 wants to merge 2 commits into
moja-global:masterfrom
demigod-11:refactor/refactor_api

Conversation

@demigod-11
Copy link
Copy Markdown

Pull Request Template

Description

refactored "/gcbm/upload/miscellaneous", "/gcbm/upload/classifiers", "/gcbm/upload/disturbances" endpoints
created a service to handle the endpoint functionality thereby keeping the code clean.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

ran flask locally and pytest

Additional Context (Please include any Screenshots/gifs if relevant)

...

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have tagged the reviewers in a comment below incase my pull request is ready for a review
  • I have signed the commit message to agree to Developer Certificate of Origin (DCO) (to certify that you wrote or otherwise have the right to submit your contribution to the project.) by adding "--signoff" to my git commit command.

@demigod-11
Copy link
Copy Markdown
Author

@SanjaySinghRajpoot

Signed-off-by: Ügochukwu Nwamanna <llousvamel11@gmail.com>
Signed-off-by: Ügochukwu Nwamanna <llousvamel11@gmail.com>
@demigod-11 demigod-11 force-pushed the refactor/refactor_api branch from a341efe to 43f1388 Compare November 27, 2022 16:53
@aornugent
Copy link
Copy Markdown
Contributor

Hey @demigod-11 - thanks for these changes. We have a lot of areas where our code can be streamlined. Could you please compare #206 and #163 and help us understand if your improvement to the upload endpoint can be made as part of a larger suite of changes?

Closing this for now. Thank you.

@aornugent aornugent closed this Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants