Skip to content

Refactor Flask REST API#203

Closed
dhirensr wants to merge 2 commits intomoja-global:masterfrom
dhirensr:refactor_api
Closed

Refactor Flask REST API#203
dhirensr wants to merge 2 commits intomoja-global:masterfrom
dhirensr:refactor_api

Conversation

@dhirensr
Copy link
Copy Markdown

@dhirensr dhirensr commented Oct 23, 2022

catching some exceptions which were previously not caught in views of the api and change variable names for readability.

Pull Request Template

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

running flask locally

Additional Context (Please include any Screenshots/gifs if relevant)

...

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • [] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have tagged the reviewers in a comment below incase my pull request is ready for a review
  • I have signed the commit message to agree to Developer Certificate of Origin (DCO) (to certify that you wrote or otherwise have the right to submit your contribution to the project.) by adding "--signoff" to my git commit command.

catching some exceptions which were previously not
caught in views of the api and change variable names
for readability.

Signed-off-by: dhirensr <dhirensr@gmail.com>
@aornugent
Copy link
Copy Markdown
Contributor

Closing this in favour of #206

@aornugent aornugent closed this Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants