Refactor GCBM API suggestion#202
Closed
temitayopelumi wants to merge 6 commits intomoja-global:masterfrom
Closed
Conversation
HarshCasper
requested changes
Oct 23, 2022
Member
HarshCasper
left a comment
There was a problem hiding this comment.
Hi — Thanks a lot for working on this! I would however hold my review on this PR since we wanted to have a plan for the OOP refactor but not actually start with the implementation yet. In case you are selected for Outreachy, we can continue working off this PR (which would need to be rebased with some upcoming new refactors and features). I hope that is fine and I would like to thank you for all the efforts 🙏 🤗
Contributor
|
Hi @temitayopelumi - I think your changes are very aligned with those proposed in #206 and think we should migrate your efforts to the same branch. Thank you for your understanding. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hello mentors. In reference to the task given for project two.
I will like to suggest this approach after looking at the FLINT demo last weekend and PR163.
The
set_attributemethod in the GCBMSimulation class that allows the user set input configuration.This is still a work in progress. It is not a complete design. But it addresses most of the concerns raised in PR163 and will work well for the current Flint-UI.
I will be glad if I can get the mentor's Feedback on this.
@aornugent @Namyalg @HarshCasper @SanjaySinghRajpoot @Janvi-Thakkar @YashKandalkar