Skip to content

feat: added expected JSON response on successful execution of endpoints for FLINT Example.#200

Open
Freeman-kuch wants to merge 4 commits intomoja-global:masterfrom
Freeman-kuch:feat/expected_response
Open

feat: added expected JSON response on successful execution of endpoints for FLINT Example.#200
Freeman-kuch wants to merge 4 commits intomoja-global:masterfrom
Freeman-kuch:feat/expected_response

Conversation

@Freeman-kuch
Copy link
Copy Markdown

Description

Updated the Curl.md to show expected Responses on successful execution of endpoints of FLINT example.

Fixes #186

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested using the Preview Functionality on VScode.

preview of curl

Also works Fine on GitHub

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have tagged the reviewers in a comment below incase my pull request is ready for a review
  • I have signed the commit message to agree to Developer Certificate of Origin (DCO) (to certify that you wrote or otherwise have the right to submit your contribution to the project.) by adding "--signoff" to my git commit command.

@Freeman-kuch Freeman-kuch force-pushed the feat/expected_response branch from aa414f1 to 9f73a9e Compare October 17, 2022 13:56
Namyalg
Namyalg previously approved these changes Oct 17, 2022
Copy link
Copy Markdown
Member

@Namyalg Namyalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
cc : @padmajabhol

Copy link
Copy Markdown
Member

@HarshCasper HarshCasper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The JSON and CSV response is not indented as per the rest of the documentation.

@Freeman-kuch
Copy link
Copy Markdown
Author

The JSON and CSV response is not indented as per the rest of the documentation.

alright, Working on it

Signed-off-by: Freeman <freemanoparaocha@gmail.com>
Signed-off-by: Freeman <freemanoparaocha@gmail.com>
@Freeman-kuch Freeman-kuch force-pushed the feat/expected_response branch from 77b2032 to 007dcec Compare October 18, 2022 13:51
@Freeman-kuch Freeman-kuch requested review from Namyalg and removed request for HarshCasper October 18, 2022 14:00
@aornugent
Copy link
Copy Markdown
Contributor

@HarshCasper - are you happy with the latest changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add expected JSON response on successful execution of endpoints for FLINT Example

4 participants