Use port aliases for audio hardware port display names#163
Open
laenzlinger wants to merge 1 commit into
Open
Conversation
Apply get_port_name_alias() to audio ports, same as already done for MIDI ports. This allows custom hardware to set JACK port aliases (e.g. via jack_alias) and have them displayed in the UI. Falls back to the existing name.title() behavior when no alias is set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use
get_port_name_alias()for audio hardware ports, same as already done for MIDI ports (line 616). This allows custom hardware to set JACK port aliases and have them displayed correctly in the UI.Problem
Audio port display names are derived from the raw JACK port name (
capture_1→Capture_1). For custom hardware (non-MOD devices running mod-ui), there's no way to show meaningful names like "IN L" or "Guitar In".Solution
Replace
name.title()withself.get_port_name_alias("system:" + name)which:jack_alias)portname.split(":",1)[-1].title()when no alias exists (backward compatible)This is the same function already used for MIDI port names.
Testing
Tested on Raspberry Pi CM5 with custom I2S soundcard (PCM1863 + PCM5242). JACK aliases set via systemd service
ExecStartPost. UI correctly displays custom port names.