Skip to content

Optimize configureInstaller() to use PECL only when needed #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
taai wants to merge 2 commits into
base: master
Choose a base branch
from
+11 −3
Open

Optimize configureInstaller() to use PECL only when needed #1236

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b877d22
Optimize configureInstaller() to use PECL only when needed
taai Feb 25, 2026
7177220
Fix coding style issue.
taai Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions install-php-extensions
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5130,11 +5130,19 @@ moduleMayUsePecl() {
# USE_PICKLE 0: no, 1: yes (already downloaded), 2: yes (build it from source)
configureInstaller() {
USE_PICKLE=0
local PHP_MODULE_TO_INSTALL
local NEEDS_PECL=0
for PHP_MODULE_TO_INSTALL in $PHP_MODULES_TO_INSTALL; do
if moduleMayUsePecl "$PHP_MODULE_TO_INSTALL"; then
NEEDS_PECL=1
break
fi
done
if test $NEEDS_PECL -eq 0; then
return
fi
if ! which pecl >/dev/null; then
for PHP_MODULE_TO_INSTALL in $PHP_MODULES_TO_INSTALL; do
if ! moduleMayUsePecl "$PHP_MODULE_TO_INSTALL"; then
continue
fi
if false && anyStringInList '' "$PHP_MODULES_TO_INSTALL"; then
USE_PICKLE=2
else
Expand Down