Skip to content

perf(storage): fetch enclosures in GetEntries in GetEntry #4442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jvoisin wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −5
Draft

perf(storage): fetch enclosures in GetEntries in GetEntry #4442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions internal/storage/entry_query_builder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,7 @@ func (e *EntryQueryBuilder) CountEntries() (count int, err error) {
// GetEntry returns a single entry that match the condition.
func (e *EntryQueryBuilder) GetEntry() (*model.Entry, error) {
e.limit = 1
e.fetchEnclosures = true
entries, err := e.GetEntries()
if err != nil {
return nil, err
Expand All @@ -258,11 +259,6 @@ func (e *EntryQueryBuilder) GetEntry() (*model.Entry, error) {
return nil, nil
}

entries[0].Enclosures, err = e.store.EnclosuresByEntryID(entries[0].ID)
if err != nil {
return nil, err
}

return entries[0], nil
}

Expand Down
Loading