perf(internal): reorder some struct members#4427
Draft
jvoisin wants to merge 1 commit into
Draft
Conversation
This saves a handful of memory space, and was done with aligo (https://github.com/essentialkaos/aligo), mostly `aligo check ./...` and `aligo view ./whatever/package`. While the changes might not seem that impactful, some are dropping space taken by some structures enough to save some words (assuming 64 bits architectures), which is always nice. More structures could be golfed, but it would significantly hurt readability, so let's no do it.
Contributor
|
I must admit I like the approach. Every time I check out alignment linters they just make structs look unintuitive. And within big codebase they only produce noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This saves a handful of memory space, and was done with aligo (https://github.com/essentialkaos/aligo), mostly
aligo check ./...andaligo view ./whatever/package.While the changes might not seem that impactful, some are dropping space taken by some structures enough to save some words (assuming 64 bits architectures), which is always nice.
More structures could be golfed, but it would significantly hurt readability, so let's no do it.