Repository navigation
Support short item descriptions - #291
Merged
Merged
Conversation
SmallJoker
reviewed
Aug 5, 2026
| data.index = index | ||
| data.dtime = 0 | ||
| local lang_code = core.get_player_information(player:get_player_name()).lang_code | ||
| local lang_code = core.get_player_information(name).lang_code |
Member
There was a problem hiding this comment.
Note to myself: cache this.
Note to myself: make the "Only names" feature per-player configurable.
SmallJoker
approved these changes
Aug 5, 2026
Member
There was a problem hiding this comment.
Looks good and works. Thanks.
Unfortunately, get_short_description is not prefect either. luanti-org/luanti#12566. This could be circumvented by first translating the description and then trimming it to the first line.
Will merge in a few days unless you'd like to make adjustments or there are objections.
Author
|
The consensus in that issue is for mods to avoid multi-line translations, but since we are already translating the description it makes sense to avoid breaking it anyway. |
Member
|
Thanks. Looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the item description HUD display code to support short descriptions, including those set in metadata.