Skip to content

buttons for selectively hiding recipe types - #280

Open
The4codeblocks wants to merge 6 commits into
minetest-mods:masterfrom
The4codeblocks:patch-1
Open

The4codeblocks wants to merge 6 commits into
minetest-mods:masterfrom
The4codeblocks:patch-1

Conversation

@The4codeblocks

Copy link
Copy Markdown

possible implementation of #269's goal

@The4codeblocks
The4codeblocks marked this pull request as ready for review June 4, 2026 16:24
@SmallJoker

SmallJoker commented Jun 5, 2026 •

Copy link
Copy Markdown
Member
comparison

^ FYI: A comparison image like this would be nice to have for PRs that touch the interface (or graphics in general).

A few remarks:

  1. The recipe bucket:bucket_empty ("Freezing" recipe provided by technic) causes a warning - nil is not a valid texture name. Same for "Alloying", basic_materials:brass_ingot.
  2. The left-side alignment is inconsistent with other elements.
  3. How about showing these filters under the < > buttons?
  4. Shaped and shapeless (Crafting + Mixing) have identical icons, hence cannot be distinguished without checking the tooltip.
  5. EDIT: I'd expect the filter buttons to behave like the categories. After clicking a button, only the recipes that belong to that craft type is shown. I.e. invert the functionality from blacklist to whitelist.

@The4codeblocks

Copy link
Copy Markdown
Author
1. The recipe `bucket:bucket_empty` ("Freezing" recipe provided by `technic`) causes a warning - `nil` is not a valid texture name. Same for "Alloying", `basic_materials:brass_ingot`.

I'm not getting either warning (I'm using technic plus)

2. The left-side alignment is inconsistent with other elements.

they're not exactly the same type

3. How about showing these filters under the `<` `>` buttons?

in what direction? (LTR or RTL?)

4. Shaped and shapeless (Crafting + Mixing) have identical icons, hence cannot be distinguished without checking the tooltip.

what ideas do you have for changing the mixing icon

5. EDIT: I'd expect the filter buttons to behave like the categories. After clicking a button, only the recipes that belong to that craft type is shown. I.e. invert the functionality from blacklist to whitelist.

it's as simple as unchecking all and selecting the intended tab?
also is that change necessary for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants