Repository navigation
Fix CI Go version drift, releases pagination, and add GitHub token auth - #72
Merged
Merged
Conversation
x/net v0.52.0+ requires go.mod's go directive at 1.25.0+, but CI still pinned actions/setup-go to 1.22.4, failing every make test run. Bump go.mod/Makefile to 1.26.4 and switch CI to go-version-file: go.mod so CI always tracks go.mod and can't drift again. Assisted-by: Claude Code/claude-sonnet-5
per-page flag had -skip-rc's description copy-pasted onto it. Releases fetch also only pulled a single page (100 newest), so -releases missed older point releases once total release count grew past --per-page. Now paginates through all pages, stopping gracefully at GitHub's 1000-result cap on this endpoint instead of failing. Assisted-by: Claude Code/claude-sonnet-5
Client was always unauthenticated, capped at 60 req/hr, which the new release pagination burns through fast. Use GITHUB_TOKEN env var when set (go-github's WithAuthToken) to raise the cap to 5,000 req/hr. Assisted-by: Claude Code/claude-sonnet-5
-per-page help text in the usage block still showed the old copy-pasted description. Download example was pinned to the long-gone 0.1.3 release; bump to 0.2.1 and point at the releases page. Assisted-by: Claude Code/claude-sonnet-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
go-version-file: go.modso the runner version can't drift from go.mod again (was causing everymake testrun to fail).-per-pageflag's copy-pasted help text.GITHUB_TOKENenv var support (go-github'sWithAuthToken) to raise the 60 req/hr unauthenticated cap to 5,000/hr, since pagination now issues more requests.Test plan
go build ./...andmake testpass locallygo run ./cmd/rke2diff -releases | grep 1.33now returns the full 1.33.x range (verified via authenticated run)GITHUB_TOKENauth end-to-end with a real token🤖 Generated with Claude Code