Security: Placeholder Error Mapping in Request Builders#1466
Closed
tomaioo wants to merge 1 commit into
Closed
Conversation
All request builder classes use 'XXX' as a placeholder in error_mapping dictionaries: `error_mapping: dict[str, type[ParsableFactory]] = {'XXX': ODataError}`. This placeholder was not replaced during code generation and indicates incomplete error handling for HTTP status codes.
Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Placeholder Error Mapping in Request Builders
Problem
Severity:
Medium| File:msgraph/generated/admin/service_announcement/messages/archive/archive_request_builder.py:L47All request builder classes use 'XXX' as a placeholder in error_mapping dictionaries:
error_mapping: dict[str, type[ParsableFactory]] = {'XXX': ODataError}. This placeholder was not replaced during code generation and indicates incomplete error handling for HTTP status codes.Solution
Replace 'XXX' placeholder with actual HTTP status code mappings (e.g., '4XX', '5XX', or specific codes like '400', '401', '403', '404', '500') to properly handle API error responses.
Changes
msgraph/generated/admin/service_announcement/messages/archive/archive_request_builder.py(modified)