Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the Sessions “Changes” view by ensuring files/folders are consistently sorted, aligning the Sessions changes UI behavior with other tree/list views in the codebase.
Changes:
- Add a custom
ITreeSorterto sort entries in both List and Tree modes. - Switch to
basenamefrombase/common/resources(URI-based) for repo display names and ARIA labels. - Use shared comparer utilities (
comparePaths,compareFileNames) for consistent ordering.
Show a summary per file
| File | Description |
|---|---|
src/vs/sessions/contrib/changes/browser/changesView.ts |
Introduces a tree sorter for stable file/folder ordering and normalizes basename handling to URI-based helpers. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
justschen
previously approved these changes
Apr 5, 2026
auto-merge was automatically disabled
April 5, 2026 21:17
Pull Request is not mergeable
Collaborator
|
ope this one has conflicts now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #307754