Skip to content

fix: improve vendor configuration handling in LanguageModelsService #307896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
DonJayamanne wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −4
Draft

fix: improve vendor configuration handling in LanguageModelsService #307896

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb236a1
fix: improve vendor configuration handling in LanguageModelsService
DonJayamanne Apr 5, 2026
56a2f57
Fixes
DonJayamanne Apr 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/vs/workbench/contrib/chat/common/languageModels.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -877,10 +877,10 @@ export class LanguageModelsService implements ILanguageModelsService {
continue;
}

// For the default vendor, groups that only have per-model config
// should not trigger a separate model resolution call.
// For vendors without a configuration schema, groups only carry per-model
// settings and should not trigger a separate model resolution call.
// Instead, apply the per-model config to the already-resolved models.
if (vendor.isDefault && !vendor.configuration) {
if (!vendor.configuration) {
if (group.settings) {
for (const model of allModels) {
const modelConfig = group.settings[model.metadata.id];
Expand Down Expand Up @@ -1119,7 +1119,9 @@ export class LanguageModelsService implements ILanguageModelsService {
}
} else if (Object.keys(updatedConfig).length > 0) {
// Only create a new group if there's non-default config
const vendor = this.getVendors().find(v => v.vendor === metadata.vendor);
// Use _vendors directly instead of getVendors() which filters by `when` clause,
// because we need to store config for all vendors regardless of UI visibility.
const vendor = this._vendors.get(metadata.vendor);
if (!vendor) {
return;
}
Expand Down
Loading