Git - warn that changes will be LOST when force deleting worktree#307879
Open
yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
Open
Git - warn that changes will be LOST when force deleting worktree#307879yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Make the force-delete confirmation for a worktree with modified or untracked files explicit about data loss, matching the existing 'IRREVERSIBLE / FOREVER LOST' language used for discard changes. Fixes microsoft#286100
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @lszomoruMatched files:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Make the force-delete confirmation for a worktree with modified or untracked files explicit about data loss.
Fixes #286100
Current behavior
When attempting to delete a worktree that contains modified or untracked files, the user sees:
This does not clearly communicate that the user's uncommitted work will be permanently lost if they proceed.
New behavior
The dialog now includes an explicit detail message, matching the
IRREVERSIBLE/FOREVER LOSTlanguage already used in the discard-changes flow (_cleanTrackedChanges/getDiscardUntrackedChangesDialogDetailsinextensions/git/src/commands.ts):Notes
l10n.t.extensions/git/src/repository.ts.