Skip to content

Reduce settings change noise #14622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bobbrow merged 4 commits into from
Jul 30, 2026
+8 −2
Merged

Reduce settings change noise #14622

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
feae077
Reduce settings change noise
bobbrow Jul 29, 2026
191a47e
address PR feedback
bobbrow Jul 30, 2026
5b81435
Merge branch 'main' into bobbrow/reduceSettingsChangeNoise
bobbrow Jul 30, 2026
2fa1d09
Merge branch 'main' into bobbrow/reduceSettingsChangeNoise
bobbrow Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Extension/src/LanguageServer/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,9 @@ export function updateLanguageConfigurations(): void {
async function onDidChangeSettings(event: vscode.ConfigurationChangeEvent): Promise<void> {
clients.forEach(client => {
if (client instanceof DefaultClient) {
void client.onDidChangeSettings(event).catch(logAndReturn.undefined);
if (['C_Cpp', 'files', 'editor', 'search', 'workbench'].some(section => event.affectsConfiguration(section, client.RootUri))) {
void client.onDidChangeSettings(event).catch(logAndReturn.undefined);
}
Comment thread
bobbrow marked this conversation as resolved.
Outdated
}
});
}
Expand Down
Loading