[soundtouch] atlmfc dependency changed for DLL version + CMake include path order#51162
Merged
BillyONeal merged 5 commits intomicrosoft:masterfrom Apr 15, 2026
Merged
[soundtouch] atlmfc dependency changed for DLL version + CMake include path order#51162BillyONeal merged 5 commits intomicrosoft:masterfrom
BillyONeal merged 5 commits intomicrosoft:masterfrom
Conversation
Contributor
Author
|
Building a static library on Windows without MFC was not possible. This patch allows a static build without "atlmfc" dependency. As bonus (the patch), The include path is now in the good order for CMake. |
Contributor
Author
|
How can I be promoted to someone that could approve changes ? (only if I mastery the port, naturally ^^ ) |
Contributor
Author
|
Sorry, I did not see the #51085 issue before :-/ It's only a problem with the include order and CMake. |
BillyONeal
approved these changes
Apr 15, 2026
Member
BillyONeal
left a comment
There was a problem hiding this comment.
Ah, this makes a lot more sense. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./vcpkg x-add-version --alland committing the result.