@microsoft-github-policy-service agree

There appear to be a number of legitimate feature test failures for that port; I'm not sure whether that's a change vs. the status quo though. Please investigate whether those are expected failures on the part of the port (in which case those features should probably be guarded with a "supports" expression), or unexpected (in which case they probably need arrow-adbc[that feature]:that triplet=feature-fails added to scripts/ci.feature.baseline.txt)

Thanks for the update submission!

AI review:

vcpkg CI Failure Report

Build: #129921
PR: #51144 — Update arrow-adbc port by @IIFE
Result: failed | Finished: 2026-04-13T21:47:47Z

Summary

Total: 7 failed jobs, 0 REGRESSION lines. The core arrow-adbc port builds successfully on all triplets. Failures are caused by 3 distinct issues: Go-dependent feature test failures, stale feature baseline entries, and a version validation error.

🔴 Issue 1: Version Validation Error

Triplet: x86-windows (affects all triplets — x86 just runs validation first)
Failed task: "Validate version files"

• Error:

  ports/arrow-adbc/vcpkg.json: error: arrow-adbc@22 was not found in versions database
  versions/baseline.json: error: arrow-adbc is assigned 16, but the local port is 22
  note: run 'vcpkg x-add-version arrow-adbc' to add the new port version
  

• Analysis: The port was updated to version 22 but the version database wasn't regenerated. The PR checklist says x-add-version --all was run, but the versions file still shows version 16.
• Fix: Run vcpkg x-add-version arrow-adbc and commit the updated versions/a-/arrow-adbc.json and versions/baseline.json.

🔴 Issue 2: Go-Dependent Features Fail on All Non-Windows Triplets

Triplets: x64-linux, arm64-osx, x64-android, arm64-android, arm-neon-android
Affected features: flightsql, snowflake, bigquery (and all combination)

arm64-osx: Go Not Found

• Error:

  Could not find GO_BIN using the following names: go
  

• Analysis: The flightsql, snowflake, and bigquery drivers are implemented in Go (using CGo). The macOS CI agent doesn't have Go installed. The same error occurs on all 3 Android triplets.

x64-linux: Go Permission Denied

• Error:

  go: could not create module cache: mkdir /go: permission denied
  

• Analysis: Go is installed on the Linux CI agent but the module cache directory (/go) isn't writable. The Go build tries to create GOPATH at /go and fails.

Impact

The core arrow-adbc[core] build passes on all platforms. Only the Go-based optional features fail. This is a pre-existing limitation — the previous version (16) had these same features marked as failing in ci.feature.baseline.txt:

arrow-adbc[bigquery]:arm64-linux=feature-fails  # Could not find GO_BIN
arrow-adbc[flightsql]:arm64-linux=feature-fails
arrow-adbc[snowflake]:arm64-linux=feature-fails

However, these baseline entries only cover arm64-linux. The new version (22) now also tests these features on other triplets where Go is also unavailable, causing new unexpected failures.

• Fix: Add feature baseline entries for all affected triplets:

  arrow-adbc[bigquery]=feature-fails  # Go required but not available in CI
  arrow-adbc[flightsql]=feature-fails
  arrow-adbc[snowflake]=feature-fails
  

  Or use triplet-specific entries if some triplets should be expected to pass.

🟡 Issue 3: Feature Baseline Coverage Gap

Triplets: x64-linux, arm-neon-android, arm64-android, x64-android, arm64-osx

The Go-dependent features (flightsql, snowflake, bigquery) fail on these triplets but there are no corresponding entries in ci.feature.baseline.txt. The existing entries only cover arm64-linux:

arrow-adbc[bigquery]:arm64-linux=feature-fails  # Could not find GO_BIN
arrow-adbc[flightsql]:arm64-linux=feature-fails
arrow-adbc[snowflake]:arm64-linux=feature-fails

Since Go is unavailable on all non-Windows CI agents, the baseline needs to cover all affected triplets.

• Fix: Expand the feature baseline entries:

  arrow-adbc[bigquery]=feature-fails  # Go required but not available in CI
  arrow-adbc[flightsql]=feature-fails
  arrow-adbc[snowflake]=feature-fails
  

ℹ️ Notes

• The core arrow-adbc port (version 22) builds successfully on all 13 triplets — this is a significant improvement over version 16 which didn't support Windows
• The PR removes the arrow dependency and patches that are no longer needed — all these changes are working correctly
• The new AdbcDriverCommon cmake config fixup for static builds appears to work (Windows static triplets all pass)
• The GitHub Actions "Check" job also fails due to the same version validation issue
• The Go-based features (flightsql, snowflake, bigquery) require the Go toolchain which isn't available on most CI agents — these should be marked as feature-fails in the baseline
• The arrow-adbc[postgresql] and arrow-adbc[sqlite] features appear to work correctly (they only fail in the all_6 combination due to the Go features being included)

Required Actions for PR Author

1. Run vcpkg x-add-version arrow-adbc and commit the result
2. Update scripts/ci.feature.baseline.txt to mark Go-dependent features as failing on all non-Windows triplets

There appear to be a number of legitimate feature test failures for that port; I'm not sure whether that's a change vs. the status quo though. Please investigate whether those are expected failures on the part of the port (in which case those features should probably be guarded with a "supports" expression), or unexpected (in which case they probably need arrow-adbc[that feature]:that triplet=feature-fails added to scripts/ci.feature.baseline.txt)

Thanks for the update submission!

Thanks. I've added the non-windows Go-based features to scripts/ci.feature.baseline.txt.