Skip to content

Libspeechd: init at 0.12.1#51127

Merged
BillyONeal merged 9 commits intomicrosoft:masterfrom
ethindp:libspeechd-initial
Apr 15, 2026
Merged

Libspeechd: init at 0.12.1#51127
BillyONeal merged 9 commits intomicrosoft:masterfrom
ethindp:libspeechd-initial

Conversation

@ethindp
Copy link
Copy Markdown
Contributor

@ethindp ethindp commented Apr 12, 2026

  • Changes comply with the maintainer guide.
  • The packaged project shows strong association with the chosen port name. Check this box if at least one of the following criteria is met:
    • The project is in Repology: https://repology.org//versions
    • The project is amongst the first web search results for "" or " C++". Include a screenshot of the search engine results in the PR.
    • The port name follows the 'GitHubOrg-GitHubRepo' form or equivalent Owner-Project form.
  • Optional dependencies of the build are all controlled by the port. A dependency is controlled if it is declared an unconditional dependency in vcpkg.json, or explicitly disabled through patches or build system arguments such as CMAKE_DISABLE_FIND_PACKAGE_Xxx or VCPKG_LOCK_FIND_PACKAGE
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is brief and accurate. See adding-usage for context. Don't add a usage file if the automatically generated usage is correct.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Exactly one version is added in each modified versions file.

I'm not really a fan of how fragile the patch for this is, and it could probably be improved by a significant margin.

@ethindp ethindp force-pushed the libspeechd-initial branch from 5d802d7 to 53af59c Compare April 13, 2026 20:02
@BillyONeal
Copy link
Copy Markdown
Member

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Copy Markdown
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the nitpick about vcpkg-make. Thanks for the new port!

Also fed this to Claude Opus 4.6 to check:

We build the repo /vcpkg/buildtrees/libspeechd/src/0.12.1-5a4173c9a6.clean with:

vcpkg_configure_make(
SOURCE_PATH "${SOURCE_PATH}"
AUTOCONFIG
DETERMINE_BUILD_TRIPLET
OPTIONS
--enable-libs-only
--disable-python
--disable-doc
--without-systemdsystemunitdir
--without-systemduserunitdir
)

Please audit that repo for:

Optional dependencies
Vendored dependencies
Installed content not "LGPG-2.1-or-later"
You can see installed content at /vcpkg/packages/libspeechd_x64-linux

Pay close attention to the patch libs-only.patch which disables a bunch of optional dependencies.
Claude response

Comment thread ports/libspeechd/vcpkg.json
Comment thread ports/libspeechd/portfile.cmake Outdated
Copy link
Copy Markdown
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BillyONeal BillyONeal merged commit af26c11 into microsoft:master Apr 15, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants