Libspeechd: init at 0.12.1#51127
Merged
BillyONeal merged 9 commits intomicrosoft:masterfrom Apr 15, 2026
Merged
Conversation
5d802d7 to
53af59c
Compare
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
BillyONeal
reviewed
Apr 14, 2026
Member
BillyONeal
left a comment
There was a problem hiding this comment.
Only the nitpick about vcpkg-make. Thanks for the new port!
Also fed this to Claude Opus 4.6 to check:
We build the repo /vcpkg/buildtrees/libspeechd/src/0.12.1-5a4173c9a6.clean with:
vcpkg_configure_make(
SOURCE_PATH "${SOURCE_PATH}"
AUTOCONFIG
DETERMINE_BUILD_TRIPLET
OPTIONS
--enable-libs-only
--disable-python
--disable-doc
--without-systemdsystemunitdir
--without-systemduserunitdir
)
Please audit that repo for:
Optional dependencies
Vendored dependencies
Installed content not "LGPG-2.1-or-later"
You can see installed content at /vcpkg/packages/libspeechd_x64-linux
Pay close attention to the patch libs-only.patch which disables a bunch of optional dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owner-Projectform.vcpkg.json, or explicitly disabled through patches or build system arguments such as CMAKE_DISABLE_FIND_PACKAGE_Xxx or VCPKG_LOCK_FIND_PACKAGEvcpkg.jsonmatches what upstream says.vcpkg.jsonmatches what upstream says../vcpkg x-add-version --alland committing the result.I'm not really a fan of how fragile the patch for this is, and it could probably be improved by a significant margin.