Skip to content

libdotconf: init at 1.4.1#51126

Merged
BillyONeal merged 2 commits intomicrosoft:masterfrom
ethindp:libdotconf-initial
Apr 15, 2026
Merged

libdotconf: init at 1.4.1#51126
BillyONeal merged 2 commits intomicrosoft:masterfrom
ethindp:libdotconf-initial

Conversation

@ethindp
Copy link
Copy Markdown
Contributor

@ethindp ethindp commented Apr 12, 2026

  • Changes comply with the maintainer guide.
  • The packaged project shows strong association with the chosen port name. Check this box if at least one of the following criteria is met:
    • The project is in Repology: https://repology.org/project/libdotconf/versions
    • The project is amongst the first web search results for "" or " C++". Include a screenshot of the search engine results in the PR.
    • The port name follows the 'GitHubOrg-GitHubRepo' form or equivalent Owner-Project form.
  • Optional dependencies of the build are all controlled by the port. A dependency is controlled if it is declared an unconditional dependency in vcpkg.json, or explicitly disabled through patches or build system arguments such as CMAKE_DISABLE_FIND_PACKAGE_Xxx or VCPKG_LOCK_FIND_PACKAGE
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is brief and accurate. See adding-usage for context. Don't add a usage file if the automatically generated usage is correct.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Exactly one version is added in each modified versions file.

Worth noting that the GH repo has no releases published, so we have to go off of the version in configure.

Copy link
Copy Markdown
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some nitpicks / questions, thanks for the new port!

Comment thread ports/libdotconf/portfile.cmake Outdated
Comment thread ports/libdotconf/portfile.cmake
Comment thread ports/libdotconf/portfile.cmake Outdated
Copy link
Copy Markdown
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks!

@BillyONeal BillyONeal merged commit b490dd3 into microsoft:master Apr 15, 2026
16 checks passed
Comment on lines +15 to +16
ac_cv_func_malloc_0_nonnull=yes
ac_cv_func_realloc_0_nonnull=yes
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FTR the skipped checks are normally try-run configuration tests and a barrier for crossbuilds. They test whether these function return a valid pointer when called for zero (aka "compatible with GNU libc").
Answering "yes" means to either know the target platform, or to know that code does not rely on this particular property.
https://www.gnu.org/software/autoconf/manual/autoconf-2.60/html_node/Particular-Functions.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants