[curl] Add apple-sectrust feature#51089
[curl] Add apple-sectrust feature#51089awesomekling wants to merge 1 commit intomicrosoft:masterfrom
Conversation
|
@microsoft-github-policy-service agree |
BillyONeal
left a comment
There was a problem hiding this comment.
I think you need a
curl[core,apple-sectrust,mbedtls]=options
curl[core,apple-sectrust,wolfssl]=options
in ci.feature.baseline.txt. But I also don't see why this really should be a feature in the first place....
| list(APPEND FEATURE_OPTIONS -DCURL_USE_SCHANNEL=ON) | ||
| endif() | ||
|
|
||
| if("apple-sectrust" IN_LIST FEATURES) |
There was a problem hiding this comment.
Should this even be a feature or should we always just do it? (It's hard to imagine a case where one does not want this behavior)
| rtmp USE_LIBRTMP | ||
| httpsrr USE_HTTPSRR | ||
| ssls-export USE_SSLS_EXPORT | ||
| apple-sectrust USE_APPLE_SECTRUST |
There was a problem hiding this comment.
This looks like a newlines change but it isn't, the file is still correctly LF, this is just inserting extra spaces to get the options to line up again now that apple-sectrust is longer.
No change requested.
|
It looks like this doesn't currently blow up because we already have: so the combined feature test picks http3 and excludes gnutls, mbedtls and wolfssl. But I still think we should add lines for this (if it remains as a feature) |
| "dependencies": [ | ||
| "openssl" | ||
| ] | ||
| }, |
There was a problem hiding this comment.
Does this feature depend on openssl libs?
And do we want an apple-specific feature? A similar capability exists for Windows (CURL_CA_NATIVE).
Fixes #48355
Expose curl's
USE_APPLE_SECTRUSToption as a macOS-only feature.This lets ports opt into Apple's native certificate verification for compatible curl TLS backends without changing curl's default behavior.
This can avoid certificate verification failures on macOS for sites that are trusted by the system trust store but not by a plain OpenSSL setup.
SHA512s are updated for each updated download../vcpkg x-add-version --alland committing the result.