Skip to content

Fix Accessibility Grading Sev2 issues for 0.84 #893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamAbhi-916 merged 5 commits into from
Apr 23, 2026
Merged

Fix Accessibility Grading Sev2 issues for 0.84 #893

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7277e61
Fixing sev2 Issues
vineethkuttan Apr 16, 2026
38f48f2
update snapshot
vineethkuttan Apr 16, 2026
62b1a86
Updating it to the latest preview
vineethkuttan Apr 20, 2026
d3b9b1d
bug bash issues
vineethkuttan Apr 21, 2026
a86be51
Add ruby file
vineethkuttan Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 9 additions & 28 deletions __tests__/__snapshots__/App.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11271,7 +11271,7 @@ exports[`ScrollView Example Page 1`] = `
onResponderTerminate={[Function]}
onResponderTerminationRequest={[Function]}
onStartShouldSetResponder={[Function]}
tooltip="https://github.com/microsoft/react-native-gallery/blob/main/src/examples/ScrollViewExamplePage.tsx"
tooltip="https://github.com/microsoft/react-native-gallery/blob/main/src/examples/ScrollViewExample.tsx"
>
<Text
style={
Expand Down Expand Up @@ -16644,6 +16644,8 @@ exports[`TextInput Example Page 1`] = `
"borderColor": "#E6E6E6",
"borderWidth": 1,
"color": "#505050",
"paddingHorizontal": 8,
"paddingVertical": 8,
}
}
/>
Expand Down Expand Up @@ -17139,7 +17141,7 @@ exports[`TextInput Example Page 1`] = `
<TextInput
onChangeText={[Function]}
placeholder="A colored TextInput with bolded and italicized text..."
placeholderTextColor="rgb(0,0,0)"
placeholderTextColor="#FFFFFF"
style={
{
"backgroundColor": "rgb(52, 122, 226)",
Expand Down Expand Up @@ -30460,13 +30462,6 @@ exports[`VirtualizedList Example Page 1`] = `
</Text>
</View>
</View>
<View
style={
{
"height": 0,
}
}
/>
</View>
</RCTScrollView>
</View>
Expand Down Expand Up @@ -30772,7 +30767,7 @@ exports[`VirtualizedList Example Page 1`] = `
}
>
<Text>
50
10
</Text>
</Text>
<Text>
Expand Down Expand Up @@ -31247,7 +31242,7 @@ exports[`VirtualizedList Example Page 1`] = `
}
>
<Text>
{30}
{10}
</Text>
</Text>
<Text>
Expand Down Expand Up @@ -32150,13 +32145,6 @@ exports[`VirtualizedList Example Page 1`] = `
</Text>
</View>
</View>
<View
style={
{
"height": 0,
}
}
/>
</View>
</RCTScrollView>
</View>
Expand Down Expand Up @@ -32481,7 +32469,7 @@ exports[`VirtualizedList Example Page 1`] = `
}
>
<Text>
50
10
</Text>
</Text>
<Text>
Expand Down Expand Up @@ -33076,7 +33064,7 @@ exports[`VirtualizedList Example Page 1`] = `
}
>
<Text>
{30}
{10}
</Text>
</Text>
<Text>
Expand Down Expand Up @@ -34089,13 +34077,6 @@ exports[`VirtualizedList Example Page 1`] = `
</View>
</View>
</View>
<View
style={
{
"height": 0,
}
}
/>
</View>
</RCTScrollView>
</View>
Expand Down Expand Up @@ -34556,7 +34537,7 @@ exports[`VirtualizedList Example Page 1`] = `
}
>
<Text>
50
10
</Text>
</Text>
<Text>
Expand Down
3 changes: 3 additions & 0 deletions hello.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# This is a simple helloworld code added to bypass codeQL Checks
puts "Hello, World!"

14 changes: 7 additions & 7 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
"@react-native-clipboard/clipboard": "^1.16.1",
"lowlight": "^1.17.0",
"react": "19.2.3",
"react-native": "0.84.0-rc.5",
"react-native-windows": "0.84.0-preview.1"
"react-native": "0.84.1",
"react-native-windows": "0.84.0-preview.4"
},
"devDependencies": {
"@babel/core": "^7.25.2",
Expand All @@ -25,13 +25,13 @@
"@react-native-community/cli": "20.0.0",
"@react-native-community/cli-platform-android": "20.0.0",
"@react-native-community/cli-platform-ios": "20.0.0",
"@react-native/babel-preset": "0.84.0-rc.5",
"@react-native/eslint-config": "0.84.0-rc.5",
"@react-native/metro-config": "0.84.0-rc.5",
"@react-native/typescript-config": "0.84.0-rc.5",
"@react-native/babel-preset": "0.84.1",
"@react-native/eslint-config": "0.84.1",
"@react-native/metro-config": "0.84.1",
"@react-native/typescript-config": "0.84.1",
"@rnx-kit/jest-preset": "^0.1.17",
"@types/jest": "^29.5.13",
"@types/react": "19.1.1",
"@types/react": "19.2.3",
"@types/react-test-renderer": "19.1.0",
"eslint": "^8.19.0",
"jest": "^29.6.3",
Expand Down
2 changes: 1 addition & 1 deletion src/examples/ScrollViewExample.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ export const ScrollViewExamplePage: React.FunctionComponent<{navigation?: any}>
url: 'https://docs.microsoft.com/en-us/uwp/api/windows.ui.xaml.controls.scrollviewer?view=winrt-19041',
}}
componentType="Core"
pageCodeUrl="https://github.com/microsoft/react-native-gallery/blob/main/src/examples/ScrollViewExamplePage.tsx"
pageCodeUrl="https://github.com/microsoft/react-native-gallery/blob/main/src/examples/ScrollViewExample.tsx"
documentation={[
{
label: 'ScrollView',
Expand Down
4 changes: 3 additions & 1 deletion src/examples/TextInputExamplePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,8 @@ export const TextInputExamplePage: React.FunctionComponent<{navigation?: any}> =
borderColor: colors.border,
borderWidth: 1,
color: colors.text,
paddingHorizontal: 8,
paddingVertical: 8,
}}
onChangeText={onChangeText1}
placeholder="A simple TextInput..."
Expand Down Expand Up @@ -127,7 +129,7 @@ export const TextInputExamplePage: React.FunctionComponent<{navigation?: any}> =
}}
onChangeText={onChangeText3}
placeholder="A colored TextInput with bolded and italicized text..."
placeholderTextColor="rgb(0,0,0)"
placeholderTextColor={colors.card}
/>
</Example>
<Example
Expand Down
14 changes: 7 additions & 7 deletions src/examples/VirtualizedListExamplePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export const VirtualizedListExamplePage: React.FunctionComponent<{navigation?: a
index: index,
});

const getItemCount = (data) => 50;
const getItemCount = (data) => 10;

const renderItem = ({item}) => {
return (<Item title={item.title} index={item.index}/>);
Expand All @@ -50,7 +50,7 @@ export const VirtualizedListExamplePage: React.FunctionComponent<{navigation?: a

<VirtualizedList
data={DATA}
initialNumToRender={30}
initialNumToRender={10}
renderItem={renderItem}
keyExtractor={item => item.title}
getItemCount={getItemCount}
Expand All @@ -66,7 +66,7 @@ export const VirtualizedListExamplePage: React.FunctionComponent<{navigation?: a
index: index,
});

const getItemCount = (data) => 50;
const getItemCount = (data) => 10;

const renderItem = ({item}) => {
return (<Item title={item.title} index={item.index}/>);
Expand All @@ -82,7 +82,7 @@ export const VirtualizedListExamplePage: React.FunctionComponent<{navigation?: a
return (
<VirtualizedList
data={DATA}
initialNumToRender={30}
initialNumToRender={10}
renderItem={renderItem}
keyExtractor={item => item.title}
getItemCount={getItemCount}
Expand All @@ -101,7 +101,7 @@ export const VirtualizedListExamplePage: React.FunctionComponent<{navigation?: a
index: index,
});

const getItemCount = (data) => 50;
const getItemCount = (data) => 10;

const Item3 = ({title, index}) => (
<Pressable
Expand Down Expand Up @@ -189,7 +189,7 @@ export const VirtualizedListExamplePage: React.FunctionComponent<{navigation?: a
const [focusedIndex2, setFocusedIndex2] = useState<number | null>(null);
const [focusedIndex3, setFocusedIndex3] = useState<number | null>(null);

const ITEM_COUNT = 50;
const ITEM_COUNT = 10;

// Arrow key navigation handler factory
const createKeyDownHandler = (
Expand Down Expand Up @@ -249,7 +249,7 @@ export const VirtualizedListExamplePage: React.FunctionComponent<{navigation?: a
index: index,
});

const getItemCount = () => 50;
const getItemCount = () => 10;

const styles = StyleSheet.create({
container: {
Expand Down
54 changes: 27 additions & 27 deletions windows/rngallery.Package/packages.lock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
},
"boost": {
"type": "Transitive",
"resolved": "1.83.0",
"contentHash": "cy53VNMzysEMvhBixDe8ujPk67Fcj3v6FPHQnH91NYJNLHpc6jxa2xq9ruCaaJjE4M3YrGSHDi4uUSTGBWw6EQ=="
"resolved": "1.84.0",
"contentHash": "4el2YP3cNJDVFPdzOso+LxGvdWP2rHxML4siq8VdonNypW2m4q503tHfCj6vK0L1UfxioE2hpFGb4ITEua73tg=="
},
"Microsoft.JavaScript.Hermes": {
"type": "Transitive",
Expand All @@ -31,15 +31,15 @@
},
"Microsoft.ReactNative": {
"type": "Transitive",
"resolved": "0.84.0-preview.1",
"contentHash": "zRr5w7VMaVJEkhsPOYt/4UX8lbmj7tUqEaKYShuYxMoSCqLt8j6q3+2od1JQQ9R03ANJ0PsOlvcnwNex7yohFw=="
"resolved": "0.84.0-preview.4",
"contentHash": "AF2pY/mfRq/SHS3zH6D2YDWD0qDjocdpZYjA+2L0023dWrFlF9tyROdtTOzySdV2/OnFyPZV68jGqejYMzuFoA=="
},
"Microsoft.ReactNative.Cxx": {
"type": "Transitive",
"resolved": "0.84.0-preview.1",
"contentHash": "hVEPhy5FGh30XUZ8oiEtkO/hhz26ACafCcb2CvaPOuKjOAiZ/JF3TnAj/iLpE9Y3kpWgsQTmWkFmB8+8ykPiBw==",
"resolved": "0.84.0-preview.4",
"contentHash": "g7KClubGrnF5S0jpxAueKhXV9311AkqjsONaRutkirgFr1DMJeUWiw0g672hwtL8CZmhCOv6l9faENmAq0Cgmg==",
"dependencies": {
"Microsoft.ReactNative": "0.84.0-preview.1"
"Microsoft.ReactNative": "0.84.0-preview.4"
}
},
"Microsoft.VCRTForwarders.140": {
Expand Down Expand Up @@ -144,31 +144,31 @@
"clipboard": {
"type": "Project",
"dependencies": {
"Microsoft.ReactNative": "[0.84.0-preview.1, )",
"Microsoft.ReactNative.Cxx": "[0.84.0-preview.1, )",
"Microsoft.ReactNative": "[0.84.0-preview.4, )",
"Microsoft.ReactNative.Cxx": "[0.84.0-preview.4, )",
"Microsoft.VCRTForwarders.140": "[1.0.2-rc, )",
"Microsoft.WindowsAppSDK": "[1.8.260209005, )",
"boost": "[1.83.0, )"
"boost": "[1.84.0, )"
}
},
"rngallery": {
"type": "Project",
"dependencies": {
"Clipboard": "[1.0.0, )",
"Microsoft.JavaScript.Hermes": "[0.0.0-2512.22001-bc3d0ed7, )",
"Microsoft.ReactNative": "[0.84.0-preview.1, )",
"Microsoft.ReactNative.Cxx": "[0.84.0-preview.1, )",
"Microsoft.ReactNative": "[0.84.0-preview.4, )",
"Microsoft.ReactNative.Cxx": "[0.84.0-preview.4, )",
"Microsoft.VCRTForwarders.140": "[1.0.2-rc, )",
"Microsoft.WindowsAppSDK": "[1.8.260209005, )",
"boost": "[1.83.0, )"
"boost": "[1.84.0, )"
}
}
},
"UAP,Version=v10.0.17763/win10-arm": {
"Microsoft.ReactNative": {
"type": "Transitive",
"resolved": "0.84.0-preview.1",
"contentHash": "zRr5w7VMaVJEkhsPOYt/4UX8lbmj7tUqEaKYShuYxMoSCqLt8j6q3+2od1JQQ9R03ANJ0PsOlvcnwNex7yohFw=="
"resolved": "0.84.0-preview.4",
"contentHash": "AF2pY/mfRq/SHS3zH6D2YDWD0qDjocdpZYjA+2L0023dWrFlF9tyROdtTOzySdV2/OnFyPZV68jGqejYMzuFoA=="
},
"Microsoft.VCRTForwarders.140": {
"type": "Transitive",
Expand All @@ -193,8 +193,8 @@
"UAP,Version=v10.0.17763/win10-arm-aot": {
"Microsoft.ReactNative": {
"type": "Transitive",
"resolved": "0.84.0-preview.1",
"contentHash": "zRr5w7VMaVJEkhsPOYt/4UX8lbmj7tUqEaKYShuYxMoSCqLt8j6q3+2od1JQQ9R03ANJ0PsOlvcnwNex7yohFw=="
"resolved": "0.84.0-preview.4",
"contentHash": "AF2pY/mfRq/SHS3zH6D2YDWD0qDjocdpZYjA+2L0023dWrFlF9tyROdtTOzySdV2/OnFyPZV68jGqejYMzuFoA=="
},
"Microsoft.VCRTForwarders.140": {
"type": "Transitive",
Expand All @@ -219,8 +219,8 @@
"UAP,Version=v10.0.17763/win10-arm64-aot": {
"Microsoft.ReactNative": {
"type": "Transitive",
"resolved": "0.84.0-preview.1",
"contentHash": "zRr5w7VMaVJEkhsPOYt/4UX8lbmj7tUqEaKYShuYxMoSCqLt8j6q3+2od1JQQ9R03ANJ0PsOlvcnwNex7yohFw=="
"resolved": "0.84.0-preview.4",
"contentHash": "AF2pY/mfRq/SHS3zH6D2YDWD0qDjocdpZYjA+2L0023dWrFlF9tyROdtTOzySdV2/OnFyPZV68jGqejYMzuFoA=="
},
"Microsoft.VCRTForwarders.140": {
"type": "Transitive",
Expand All @@ -245,8 +245,8 @@
"UAP,Version=v10.0.17763/win10-x64": {
"Microsoft.ReactNative": {
"type": "Transitive",
"resolved": "0.84.0-preview.1",
"contentHash": "zRr5w7VMaVJEkhsPOYt/4UX8lbmj7tUqEaKYShuYxMoSCqLt8j6q3+2od1JQQ9R03ANJ0PsOlvcnwNex7yohFw=="
"resolved": "0.84.0-preview.4",
"contentHash": "AF2pY/mfRq/SHS3zH6D2YDWD0qDjocdpZYjA+2L0023dWrFlF9tyROdtTOzySdV2/OnFyPZV68jGqejYMzuFoA=="
},
"Microsoft.VCRTForwarders.140": {
"type": "Transitive",
Expand All @@ -271,8 +271,8 @@
"UAP,Version=v10.0.17763/win10-x64-aot": {
"Microsoft.ReactNative": {
"type": "Transitive",
"resolved": "0.84.0-preview.1",
"contentHash": "zRr5w7VMaVJEkhsPOYt/4UX8lbmj7tUqEaKYShuYxMoSCqLt8j6q3+2od1JQQ9R03ANJ0PsOlvcnwNex7yohFw=="
"resolved": "0.84.0-preview.4",
"contentHash": "AF2pY/mfRq/SHS3zH6D2YDWD0qDjocdpZYjA+2L0023dWrFlF9tyROdtTOzySdV2/OnFyPZV68jGqejYMzuFoA=="
},
"Microsoft.VCRTForwarders.140": {
"type": "Transitive",
Expand All @@ -297,8 +297,8 @@
"UAP,Version=v10.0.17763/win10-x86": {
"Microsoft.ReactNative": {
"type": "Transitive",
"resolved": "0.84.0-preview.1",
"contentHash": "zRr5w7VMaVJEkhsPOYt/4UX8lbmj7tUqEaKYShuYxMoSCqLt8j6q3+2od1JQQ9R03ANJ0PsOlvcnwNex7yohFw=="
"resolved": "0.84.0-preview.4",
"contentHash": "AF2pY/mfRq/SHS3zH6D2YDWD0qDjocdpZYjA+2L0023dWrFlF9tyROdtTOzySdV2/OnFyPZV68jGqejYMzuFoA=="
},
"Microsoft.VCRTForwarders.140": {
"type": "Transitive",
Expand All @@ -323,8 +323,8 @@
"UAP,Version=v10.0.17763/win10-x86-aot": {
"Microsoft.ReactNative": {
"type": "Transitive",
"resolved": "0.84.0-preview.1",
"contentHash": "zRr5w7VMaVJEkhsPOYt/4UX8lbmj7tUqEaKYShuYxMoSCqLt8j6q3+2od1JQQ9R03ANJ0PsOlvcnwNex7yohFw=="
"resolved": "0.84.0-preview.4",
"contentHash": "AF2pY/mfRq/SHS3zH6D2YDWD0qDjocdpZYjA+2L0023dWrFlF9tyROdtTOzySdV2/OnFyPZV68jGqejYMzuFoA=="
},
"Microsoft.VCRTForwarders.140": {
"type": "Transitive",
Expand Down
Loading
Loading