Skip to content

feat(test): replace 'deferred' retry strategy with 'isolated'#41798

Merged
dgozman merged 1 commit into
microsoft:mainfrom
dgozman:retry-strategy-isolated
Jul 15, 2026
Merged

feat(test): replace 'deferred' retry strategy with 'isolated'#41798
dgozman merged 1 commit into
microsoft:mainfrom
dgozman:retry-strategy-isolated

Conversation

@dgozman

@dgozman dgozman commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • retryStrategy: 'isolated' runs retries at the end of the run, one by one in a single worker, replacing the unreleased 'deferred' value.
  • Tests that did not have a chance to run because of a failure keep their priority in the queue instead of being deferred together with retries.

With the 'isolated' retry strategy, retries run at the end of the run,
one by one in a single worker. Tests that did not have a chance to run
because of a failure keep their priority in the queue.
@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

1 failed
❌ [firefox] › mcp/annotate.spec.ts:447 › should switch screencast to -s session on show --annotate @mcp-macos-latest-firefox

7759 passed, 1249 skipped


Merge workflow run.

@dgozman dgozman requested a review from Skn0tt July 15, 2026 12:59
@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

7 flaky ⚠️ [chromium-library] › library/browsercontext-page-event.spec.ts:173 › should work with Ctrl-clicking `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:177 › serviceWorker(), and fromServiceWorker() work `@realtime-time-library-chromium-linux`
⚠️ [chromium-library] › library/video.spec.ts:356 › screencast › should work for popups `@realtime-time-library-chromium-linux`
⚠️ [chromium-library] › library/video.spec.ts:736 › screencast › should work with video+trace `@realtime-time-library-chromium-linux`
⚠️ [chromium-page] › page/workers.spec.ts:191 › should attribute network activity for worker inside iframe to the iframe `@chromium-ubuntu-22.04-node24`
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:185 › should watch new file `@ubuntu-latest-node26`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:388 › should reveal errors in the sourcetab `@windows-latest-node22`

49698 passed, 1156 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Hi, I'm the Playwright bot and I took a first look at the CI failures here.

🟢 The one failure is a pre-existing flake — this PR is clear

The only failing test is [firefox] › mcp/annotate.spec.ts:447 › should switch screencast to -s session on show --annotate, and it's a known flake that fails across main and unrelated PRs. This PR only touches the test-runner dispatcher and retry strategy, which doesn't exercise the MCP screencast/annotate path.

Details

Overall: 1 failed in the MCP workflow, 7759 passed. No failure is caused by this PR.

Pre-existing flake / infra

Triaged by the Playwright bot - agent run

@dgozman dgozman merged commit dd20c2f into microsoft:main Jul 15, 2026
46 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants