test(heap): fixme "should not leak workers" on stable Firefox#41749
Open
microsoft-playwright-automation[bot] wants to merge 1 commit into
Open
test(heap): fixme "should not leak workers" on stable Firefox#41749microsoft-playwright-automation[bot] wants to merge 1 commit into
microsoft-playwright-automation[bot] wants to merge 1 commit into
Conversation
Flaky on Firefox (Juggler) only: ~36% of firefox-library CI runs fail
(148/415 rows), always a 30s timeout. Chromium, WebKit and
moz-firefox-nightly (BiDi) never fail.
Instrumenting the loop shows the hang is always in
workerObj.waitForEvent('close'): after worker.terminate(), Firefox
sometimes never delivers the worker 'close' event, so the object is
never disposed and the leak assertion is never reached. That's a
Juggler worker-close race, not a test-side bug, so scope a fixme to
stable Firefox and keep it running everywhere else (nightly BiDi passes).
Verified locally on firefox-macos-15-xlarge (macOS 15, arm64): before
the fixme, 3 failed + 4 flaky of 8 --repeat-each; after, 3 skipped on
Firefox and still passing on Chromium. npm run flint clean.
Run: https://github.com/microsoft/playwright/actions/runs/29231981762
Suggested-reviewer: dgozman
Contributor
Test results for "MCP"3 failed 7757 passed, 1249 skipped Merge workflow run. |
Contributor
Test results for "tests 1"4 flaky49543 passed, 1162 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flaky on Firefox (Juggler) only: ~36% of firefox-library CI runs fail
(148/415 rows), always a 30s timeout. Chromium, WebKit and
moz-firefox-nightly (BiDi) never fail.
Instrumenting the loop shows the hang is always in
workerObj.waitForEvent('close'): after worker.terminate(), Firefox
sometimes never delivers the worker 'close' event, so the object is
never disposed and the leak assertion is never reached. That's a
Juggler worker-close race, not a test-side bug, so scope a fixme to
stable Firefox and keep it running everywhere else (nightly BiDi passes).
Verified locally on firefox-macos-15-xlarge (macOS 15, arm64): before
the fixme, 3 failed + 4 flaky of 8 --repeat-each; after, 3 skipped on
Firefox and still passing on Chromium. npm run flint clean.
Run: https://github.com/microsoft/playwright/actions/runs/29231981762
Suggested-reviewer: dgozman