Rewriter: fix fuse_relu_clip with None max#2843
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2843 +/- ##
==========================================
- Coverage 72.65% 72.63% -0.03%
==========================================
Files 259 259
Lines 31660 31666 +6
Branches 2981 2982 +1
==========================================
- Hits 23002 23000 -2
- Misses 7650 7656 +6
- Partials 1008 1010 +2 ☔ View full report in Codecov by Sentry. |
|
@justinchuby Test fails because the onnx=1.17 (from noxfile) doesnt allow to define clip this way ( |
Looks like we can bump onnx version now. |
|
@AyoubMDL could you help us bump the version here? |
Head branch was pushed to by a user without write access
I've upgraded it to 1.18 (which make the tests pass), tell me if you want a more recent version. |
|
What is the reason the PR cannot be merged? It's a rathe simple fix. |
Fixes #2836