Skip to content

Fix fuse_pad_into_conv incorrectly fusing when Pad contains negative values #2841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
titaiwangms merged 4 commits into from
Jun 3, 2026
+11 −0
Merged

Fix fuse_pad_into_conv incorrectly fusing when Pad contains negative values #2841

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5ba0ae8
Initial plan
Copilot Mar 4, 2026
a4c955e
fix: reject negative pad values in fuse_pad_into_conv optimization
Copilot Mar 4, 2026
94112d5
Merge branch 'main' into copilot/fix-negative-pad-values
justinchuby Jun 1, 2026
befdc9d
Merge branch 'main' into copilot/fix-negative-pad-values
titaiwangms Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions onnxscript/rewriter/rules/common/_fuse_pad_into_conv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,9 @@ def check(self, context, x: ir.Value, pad: ir.Value, conv: ir.Value) -> orp.Matc
if np.any(self._pads_list[:2] + self._pads_list[x_rank : x_rank + 2]):
self._pads_list = None
return check_result.fail(f"{pads.name} must be zero in non-spatial dimensions.")
if any(p < 0 for p in self._pads_list):
self._pads_list = None
return check_result.fail(f"{pads.name} must not contain negative values.")

return check_result

Expand Down
8 changes: 8 additions & 0 deletions onnxscript/rewriter/rules/common/_fuse_pad_into_conv_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,14 @@ def test_fuse_pad_into_conv(self, pad_pads, const_value, axes, conv_pads, conv_a
"VALID",
"auto_pad must be 'NOTSET'.",
),
(
"constant",
ir.tensor([0, 0, -1, -1, -1, 0, 0, 0, 0, 0], name="pads"),
None,
None,
"NOTSET",
"must not contain negative values",
),
]
)
def test_unsupported_fuse_pad_into_conv(
Expand Down
Loading