Replace deprecated core/modal_factory with core/modal_delete_cancel#3236
Open
patmr7 wants to merge 1 commit into
Open
Replace deprecated core/modal_factory with core/modal_delete_cancel#3236patmr7 wants to merge 1 commit into
patmr7 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the OneNote assignment feedback “delete feedback” UI to stop using the deprecated core/modal_factory and instead use Moodle’s core/modal_delete_cancel modal implementation.
Changes:
- Replace
core/modal_factorySAVE/CANCEL modal usage withcore/modal_delete_canceland bind modal creation/display on click. - Load modal title/body strings via
Promise.all([...Str.get_string(...)])before creating the modal. - Regenerate AMD build artifacts (
.min.jsand source map) to reflect the source change.
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| mod/assign/feedback/onenote/amd/src/onenotedelete.js | Switches deletion confirmation modal implementation to core/modal_delete_cancel and updates event handling accordingly. |
| mod/assign/feedback/onenote/amd/build/onenotedelete.min.js | Rebuilt minified AMD output reflecting the new modal implementation. |
| mod/assign/feedback/onenote/amd/build/onenotedelete.min.js.map | Updated source map to align with the rebuilt minified bundle and new source. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.