Replace deprecated core/modal_factory with core/modal_delete_cancel#3226
Open
patmr7 wants to merge 1 commit into
Open
Replace deprecated core/modal_factory with core/modal_delete_cancel#3226patmr7 wants to merge 1 commit into
patmr7 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the OneNote feedback deletion UI in the Assign feedback plugin to use Moodle’s newer core/modal_save_cancel API instead of the deprecated core/modal_factory save/cancel modal type.
Changes:
- Replace
core/modal_factoryusage withcore/modal_save_cancelin the AMD source module. - Switch to explicitly opening the modal on trigger click and manually calling
modal.show(). - Regenerate the built AMD artifacts (
.min.jsand sourcemap) to match the updated source.
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| mod/assign/feedback/onenote/amd/src/onenotedelete.js | Migrates deletion confirmation modal from modal_factory to modal_save_cancel and updates click handling. |
| mod/assign/feedback/onenote/amd/build/onenotedelete.min.js | Rebuilt minified bundle reflecting the new modal implementation. |
| mod/assign/feedback/onenote/amd/build/onenotedelete.min.js.map | Updated sourcemap and embedded sourcesContent for the rebuilt bundle. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
patmr7
force-pushed
the
wip-131869-m502
branch
2 times, most recently
from
0f6ee29 to
29c3b45
Compare
patmr7
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.