Convert calsync observers to async adhoc tasks#3222
Open
patmr7 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR moves Moodle calendar event syncing with Microsoft Outlook from synchronous observer execution into an asynchronous ad-hoc task, preventing long-running Graph API operations from blocking web requests (especially in large-enrolment courses).
Changes:
- Added a new
synccalendareventad-hoc task to perform create/update/delete event sync work in cron. - Updated calsync calendar event observers to enqueue the new task instead of calling Graph sync methods directly.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
local/o365/classes/feature/calsync/task/synccalendarevent.php |
Introduces the new ad-hoc task that performs the actual single-event Outlook sync based on queued custom_data. |
local/o365/classes/feature/calsync/observers.php |
Updates calendar event observers to enqueue synccalendarevent tasks for create/update/delete instead of syncing inline. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Synchronous Graph API calls in calendar event observers blocked web requests for minutes in courses with large enrolments. Replace direct sync calls with a new synccalendarevent adhoc task queued by each observer instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synchronous Graph API calls in calendar event observers blocked web requests for minutes in courses with large enrolments. Replace direct sync calls with a new synccalendarevent adhoc task queued by each observer instead.