Convert calsync observers to async adhoc tasks#3220
Open
patmr7 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR moves Microsoft Outlook calendar synchronization triggered by Moodle calendar event observers from synchronous Graph API calls (during web requests) to asynchronous processing via a new ad-hoc task, preventing long request blocking in large-enrolment courses.
Changes:
- Added a new ad-hoc task (
synccalendarevent) to perform per-event create/update/delete sync work in cron. - Updated calendar event observers to queue the ad-hoc task instead of calling Graph sync methods inline.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| local/o365/classes/feature/calsync/task/synccalendarevent.php | Introduces a new ad-hoc task to perform per-event Outlook sync actions asynchronously. |
| local/o365/classes/feature/calsync/observers.php | Switches calendar event observers to queue the new ad-hoc task rather than running sync during the request. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Synchronous Graph API calls in calendar event observers blocked web requests for minutes in courses with large enrolments. Replace direct sync calls with a new synccalendarevent adhoc task queued by each observer instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synchronous Graph API calls in calendar event observers blocked web requests for minutes in courses with large enrolments. Replace direct sync calls with a new synccalendarevent adhoc task queued by each observer instead.