Improve photo and timezone sync scheduled task

[weilai-irl]

• Better support for site not using UPN as username,
• Reduce DB queries.

[Copilot]

Pull request overview

This PR improves the scheduled photo/timezone sync task by making photo fetches more robust on sites where stored usernames aren’t valid Graph UPNs, and by reducing per-user database lookups during batch processing.

Changes:

• Switch photo sync lookups from o365name (UPN) to objectid (AAD GUID) when calling Graph batch photo APIs.
• Reduce DB queries by pre-aggregating local_o365_appassign via a single LEFT JOIN and by batch-fetching user_preferences photo hashes.
• Optimize photo application by skipping process_new_icon() when the incoming raw photo hash matches the stored hash, and refining photo-change detection in apply_photo() via file content hashes.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
local/o365/classes/task/photoandtimezonesync.php	Uses objectid for photo batch requests, avoids duplicate rows via aggregated join, and adds hash-based short-circuiting to reduce unnecessary image processing/DB work.
local/o365/classes/feature/usersync/main.php	Updates photo-apply logic to more reliably determine “content changed” vs “ID changed”, and makes apply_photo_public() return a boolean change indicator.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.