Improve photo and timezone sync scheduled task

[weilai-irl]

• Better support for site not using UPN as username,
• Reduce DB queries.

[Copilot]

Pull request overview

Improves the scheduled photo/timezone sync task in local_o365 by using Azure AD objectid for Graph photo requests (to better support non-UPN usernames) and by reducing per-user work/queries during photo application.

Changes:

• Fetch photos in batches keyed by Azure AD objectid instead of o365name/UPN.
• Add photo hash caching in user_preferences to skip process_new_icon when the raw photo hasn’t changed.
• Update apply_photo* flow to return a boolean and detect photo content changes via file content hashes (rather than picture ID comparisons).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
local/o365/classes/task/photoandtimezonesync.php	Switch photo identifier to objectid, reduce DB work via joins + preference hash caching, and apply photos more selectively.
local/o365/classes/feature/usersync/main.php	Improve photo apply semantics: return bool, clear-photo result correctness, and content-change detection via file hashes.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.