Allow only sync users from a group#3204
Open
weilai-irl wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an “only sync users from a Microsoft 365 group” capability to the local_o365 user sync pipeline, plus related logging and photo-sync optimizations.
Changes:
- Introduces an admin setting to configure a Microsoft 365 Group object ID used to scope user sync.
- Adds Graph API support for batching group members (and owners) and wires it into full user sync and photo/timezone sync.
- Enhances photo sync responses with a SHA-256 hash and updates photo application logic to (attempt to) avoid unnecessary updates.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| local/o365/settings.php | Registers the new user sync group filter setting on the user sync settings page. |
| local/o365/lang/en/local_o365.php | Adds UI strings and a detailed warning description for the new setting. |
| local/o365/classes/task/usersync.php | Logs group-filter configuration and tweaks displayed sync option filtering text. |
| local/o365/classes/task/photoandtimezonesync.php | Applies group filter to photo/timezone sync processing and adds option logging + hash-aware photo apply. |
| local/o365/classes/rest/unified.php | Adds batched group member retrieval endpoints and includes a photo hash in batch photo results. |
| local/o365/classes/feature/usersync/main.php | Uses group filter for full user sync, adds group-filter getter, and introduces hash-aware photo application/storage. |
| local/o365/classes/adminsetting/usersyncgroupfilter.php | New admin setting with GUID-format validation for the group object ID. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
weilai-irl
force-pushed
the
wip-127698-m501
branch
from
790a649 to
ce6254f
Compare
weilai-irl
force-pushed
the
wip-127698-m501
branch
from
ce6254f to
a2707e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.