Reorganise local_o365 sync settings configuration page#3199
Open
weilai-irl wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Splits the combined local_o365_sync admin settings page into two separate pages — User Sync and Course Sync — and reorders Cohort sync / Course request sections so they live on the Advanced page (before Tools). Adds backward-compat redirects and tab constants so existing links/bookmarks still resolve.
Changes:
- Replace the single
local_o365_syncsettings page with newlocal_o365_usersyncandlocal_o365_coursesyncpages, and move Cohort sync + Course request settings onto the Advanced page above Tools. - Add a legacy redirect from
section=local_o365_synctolocal_o365_usersync, two new tab constants (LOCAL_O365_TAB_USERSYNC,LOCAL_O365_TAB_COURSESYNC), and map the oldLOCAL_O365_TAB_SYNCvalue to the new User Sync page. - Update
local_o365_get_settings_nav_html()and add the correspondingsettings_header_usersync/settings_header_coursesynclanguage strings.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| local/o365/settings.php | Splits sync settings into two pages, relocates Cohort/Course-request sections to Advanced, and adds back-compat redirect for the old section URL. |
| local/o365/lib.php | Adds two new tab constants and updates the settings nav helper to list User Sync and Course Sync as separate tabs. |
| local/o365/lang/en/local_o365.php | Adds settings_header_usersync and settings_header_coursesync strings for the new tabs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
6a62fe4 to
1829a1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.