Import tiny_teamsmeeting plugin into lib/editor/tiny/plugins/teamsmeeting#3194
Open
weilai-irl wants to merge 27 commits into
Open
Import tiny_teamsmeeting plugin into lib/editor/tiny/plugins/teamsmeeting#3194weilai-irl wants to merge 27 commits into
weilai-irl wants to merge 27 commits into
Conversation
…vent it from being cleared by Tiny editor
There was a problem hiding this comment.
Pull request overview
This PR vendors the tiny_teamsmeeting TinyMCE plugin into lib/editor/tiny/plugins/teamsmeeting, adding UI, webservice, database schema, and tests to let users create/insert Microsoft Teams meeting links from the Tiny editor.
Changes:
- Added the Tiny editor plugin implementation (AMD sources + built assets) and server-side scripts (
result.php,error.php). - Added plugin infrastructure (version, capabilities, services, settings, privacy provider, install.xml) and language packs.
- Added PHPUnit + Behat coverage scaffolding and updated the repo CI matrix to include the new plugin folder.
Reviewed changes
Copilot reviewed 23 out of 41 changed files in this pull request and generated 18 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/editor/tiny/plugins/teamsmeeting/version.php | Declares plugin component/version/requires metadata. |
| lib/editor/tiny/plugins/teamsmeeting/tests/webservice_test.php | Adds PHPUnit tests (currently focused on capability checks). |
| lib/editor/tiny/plugins/teamsmeeting/tests/behat/teamsmeeting.feature | Adds Behat coverage for button visibility based on capability. |
| lib/editor/tiny/plugins/teamsmeeting/settings.php | Adds admin settings for Meetings App URL (currently not wired into admin tree). |
| lib/editor/tiny/plugins/teamsmeeting/result.php | Handles iframe result flow and meeting record persistence + postMessage to editor. |
| lib/editor/tiny/plugins/teamsmeeting/README.MD | Documents installation/usage and hosting the Meetings app. |
| lib/editor/tiny/plugins/teamsmeeting/pix/icon.svg | Provides the toolbar icon. |
| lib/editor/tiny/plugins/teamsmeeting/lang/pl/tiny_teamsmeeting.php | Adds Polish strings for UI/settings/privacy. |
| lib/editor/tiny/plugins/teamsmeeting/lang/en/tiny_teamsmeeting.php | Adds English strings for UI/settings/capability/privacy. |
| lib/editor/tiny/plugins/teamsmeeting/error.php | Renders an iframe-friendly “meeting not found” UI. |
| lib/editor/tiny/plugins/teamsmeeting/db/services.php | Declares the Ajax webservice function(s). |
| lib/editor/tiny/plugins/teamsmeeting/db/install.xml | Creates the {tiny_teamsmeeting} table (currently mismatched to code usage). |
| lib/editor/tiny/plugins/teamsmeeting/db/access.php | Defines tiny/teamsmeeting:add capability defaults. |
| lib/editor/tiny/plugins/teamsmeeting/classes/privacy/provider.php | Privacy metadata provider (currently incomplete if DB stores user data). |
| lib/editor/tiny/plugins/teamsmeeting/classes/plugininfo.php | Registers Tiny plugin buttons + configuration and enablement logic. |
| lib/editor/tiny/plugins/teamsmeeting/classes/external/get_meeting_details.php | External/Ajax function to resolve meeting details iframe URL. |
| lib/editor/tiny/plugins/teamsmeeting/amd/src/plugin.js | Tiny plugin bootstrap/registration. |
| lib/editor/tiny/plugins/teamsmeeting/amd/src/options.js | Registers Tiny options and getters. |
| lib/editor/tiny/plugins/teamsmeeting/amd/src/configuration.js | Adds the plugin button into Tiny toolbar config. |
| lib/editor/tiny/plugins/teamsmeeting/amd/src/common.js | Defines shared constants (currently exported in a way that breaks imports). |
| lib/editor/tiny/plugins/teamsmeeting/amd/src/commands.js | Implements button behavior, dialog, message handling, link marking/migration. |
| lib/editor/tiny/plugins/teamsmeeting/amd/build/plugin.min.js.map | Built sourcemap for plugin module. |
| lib/editor/tiny/plugins/teamsmeeting/amd/build/plugin.min.js | Built plugin module. |
| lib/editor/tiny/plugins/teamsmeeting/amd/build/options.min.js.map | Built sourcemap for options module. |
| lib/editor/tiny/plugins/teamsmeeting/amd/build/options.min.js | Built options module. |
| lib/editor/tiny/plugins/teamsmeeting/amd/build/configuration.min.js.map | Built sourcemap for configuration module. |
| lib/editor/tiny/plugins/teamsmeeting/amd/build/configuration.min.js | Built configuration module. |
| lib/editor/tiny/plugins/teamsmeeting/amd/build/common.min.js.map | Built sourcemap for common module. |
| lib/editor/tiny/plugins/teamsmeeting/amd/build/common.min.js | Built common module. |
| lib/editor/tiny/plugins/teamsmeeting/amd/build/commands.min.js.map | Built sourcemap for commands module. |
| lib/editor/tiny/plugins/teamsmeeting/amd/build/commands.min.js | Built commands module. |
| lib/editor/tiny/plugins/teamsmeeting/.gitlab-ci.yml | Standalone CI config (not used by this repo’s GitHub Actions). |
| lib/editor/tiny/plugins/teamsmeeting/.github/workflows/ci.yml | Standalone workflow (won’t run from a nested path in this repo). |
| .github/workflows/ci.yml | Adds the new plugin folder to the repo CI matrix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
weilai-irl
force-pushed
the
wip-130956-m405
branch
2 times, most recently
from
4d1e48b to
4abdda3
Compare
weilai-irl
force-pushed
the
wip-130956-m405
branch
from
4abdda3 to
425282c
Compare
weilai-irl
force-pushed
the
wip-130956-m405
branch
from
c495d5d to
beb64e4
Compare
weilai-irl
force-pushed
the
wip-130956-m405
branch
3 times, most recently
from
b782875 to
0f5f238
Compare
weilai-irl
force-pushed
the
wip-130956-m405
branch
from
0f5f238 to
02ce7ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.